From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3090FC282CE for ; Wed, 22 May 2019 19:32:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E83442089E for ; Wed, 22 May 2019 19:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558553546; bh=RcK3tU00by1x1i8xlsXwi4KSIoLbrcvfVHiQQcXb244=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=icdOS3WKCkl1USknxNmdhgfZeRgtbYqnaxpRZ/jwJsA7wT9GyEvYgu4SAg1nLavRO 6PfHcWIyhmr3prfmofaE3T+3xykPHTTOwnQReQzWt3aVMd1Lps8cme6W9zcv9Hwx3T Dh9jWrI8YuSUgUc96OX7mBALfP+qHC+68aNPKJRE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731046AbfEVTcY (ORCPT ); Wed, 22 May 2019 15:32:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:56024 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387777AbfEVTcP (ORCPT ); Wed, 22 May 2019 15:32:15 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC17E21473; Wed, 22 May 2019 19:32:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558553534; bh=RcK3tU00by1x1i8xlsXwi4KSIoLbrcvfVHiQQcXb244=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dd+WF4wm5L0hifIRL18iV4wZYm4Ie/8SYcTTAcCmj/8jVijbBkAW0/+3M6hIEs6yQ T332toPR8gUnJ0OI/Lc4HyfC4MsPamx5Lf0MFQEGcPsQokBWTyNC9apG73r3aKJedr hxFpIJ/F2MDqXqUcFK9chvp84R4dzmGQIrrYmmcI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Philipp Zabel , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 30/92] media: coda: clear error return value before picture run Date: Wed, 22 May 2019 15:30:25 -0400 Message-Id: <20190522193127.27079-30-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190522193127.27079-1-sashal@kernel.org> References: <20190522193127.27079-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Philipp Zabel [ Upstream commit bbeefa7357a648afe70e7183914c87c3878d528d ] The error return value is not written by some firmware codecs, such as MPEG-2 decode on CodaHx4. Clear the error return value before starting the picture run to avoid misinterpreting unrelated values returned by sequence initialization as error return value. Signed-off-by: Philipp Zabel Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/coda/coda-bit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c index d76511c1c1e3f..a4639813cf35d 100644 --- a/drivers/media/platform/coda/coda-bit.c +++ b/drivers/media/platform/coda/coda-bit.c @@ -1829,6 +1829,9 @@ static int coda_prepare_decode(struct coda_ctx *ctx) /* Clear decode success flag */ coda_write(dev, 0, CODA_RET_DEC_PIC_SUCCESS); + /* Clear error return value */ + coda_write(dev, 0, CODA_RET_DEC_PIC_ERR_MB); + trace_coda_dec_pic_run(ctx, meta); coda_command_async(ctx, CODA_COMMAND_PIC_RUN); -- 2.20.1