From: Dominique Martinet <asmadeus@codewreck.org>
To: Bharath Vedartham <linux.bhar@gmail.com>
Cc: ericvh@gmail.com, lucho@ionkov.net, linux-kernel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net
Subject: Re: [PATCH v2] 9p/cache.c: Fix memory leak in v9fs_cache_session_get_cookie
Date: Wed, 22 May 2019 21:47:33 +0200 [thread overview]
Message-ID: <20190522194733.GA4766@nautica> (raw)
In-Reply-To: <20190522194519.GA5313@bharath12345-Inspiron-5559>
Bharath Vedartham wrote on Thu, May 23, 2019:
> v9fs_cache_session_get_cookie assigns a random cachetag to v9ses->cachetag,
> if the cachetag is not assigned previously.
>
> v9fs_random_cachetag allocates memory to v9ses->cachetag with kmalloc and uses
> scnprintf to fill it up with a cachetag.
>
> But if scnprintf fails, v9ses->cachetag is not freed in the current
> code causing a memory leak.
>
> Fix this by freeing v9ses->cachetag it v9fs_random_cachetag fails.
>
> This was reported by syzbot, the link to the report is below:
> https://syzkaller.appspot.com/bug?id=f012bdf297a7a4c860c38a88b44fbee43fd9bbf3
>
> Reported-by: syzbot+3a030a73b6c1e9833815@syzkaller.appspotmail.com
> Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
Thanks!
I'm on limited internet right now but will run tests and queue this up tomorrow
--
Dominique
next prev parent reply other threads:[~2019-05-22 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 19:45 [PATCH v2] 9p/cache.c: Fix memory leak in v9fs_cache_session_get_cookie Bharath Vedartham
2019-05-22 19:47 ` Dominique Martinet [this message]
2019-05-22 19:50 ` Bharath Vedartham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522194733.GA4766@nautica \
--to=asmadeus@codewreck.org \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.bhar@gmail.com \
--cc=lucho@ionkov.net \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).