From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D4AAC282DE for ; Thu, 23 May 2019 06:12:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A92920881 for ; Thu, 23 May 2019 06:12:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728620AbfEWGMG (ORCPT ); Thu, 23 May 2019 02:12:06 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:47428 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725873AbfEWGMG (ORCPT ); Thu, 23 May 2019 02:12:06 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hTgxQ-0001Dr-VE; Thu, 23 May 2019 14:12:05 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hTgxO-0001EP-Sx; Thu, 23 May 2019 14:12:02 +0800 Date: Thu, 23 May 2019 14:12:02 +0800 From: Herbert Xu To: Iuliana Prodan Cc: Horia Geanta , Aymen Sghaier , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx Subject: Re: [PATCH v2 1/2] crypto: caam - fix pkcs1pad(rsa-caam, sha256) failure because of invalid input Message-ID: <20190523061202.ic2vgimgzvvm6dzc@gondor.apana.org.au> References: <1557919546-360-1-git-send-email-iuliana.prodan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1557919546-360-1-git-send-email-iuliana.prodan@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 15, 2019 at 02:25:45PM +0300, Iuliana Prodan wrote: > > @@ -1058,6 +1105,14 @@ static int __init caam_pkc_init(void) > goto out_put_dev; > } > > + /* allocate zero buffer, used for padding input */ > + zero_buffer = kzalloc(CAAM_RSA_MAX_INPUT_SIZE - 1, GFP_DMA | > + GFP_KERNEL); > + if (!zero_buffer) { > + err = -ENOMEM; > + goto out_put_dev; > + } > + > err = crypto_register_akcipher(&caam_rsa); > if (err) > dev_warn(ctrldev, "%s alg registration failed\n", This patch does not apply on top of the caam patch-series from Horia. You're also going to leak zero_buffer if crypto_register_akcipher fails. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt