From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EDADC04AAC for ; Thu, 23 May 2019 06:14:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63CC72133D for ; Thu, 23 May 2019 06:14:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ozlabs.org header.i=@ozlabs.org header.b="iHrJwjk2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727739AbfEWGOc (ORCPT ); Thu, 23 May 2019 02:14:32 -0400 Received: from ozlabs.org ([203.11.71.1]:45989 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725873AbfEWGOc (ORCPT ); Thu, 23 May 2019 02:14:32 -0400 Received: by ozlabs.org (Postfix, from userid 1003) id 458fNP5zgyz9s6w; Thu, 23 May 2019 16:14:29 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1558592069; bh=Tr73qojhfVjEZCm5/e8GumQVv2PX+3DhCXwgTZaf9eA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iHrJwjk21wsErNroYSoT3Ay7LcZvRgset0OR28n19aUJtizFBULwKHdwdYeELZVs7 yQPr7hIxjT5QEbkSpu3LKQ6llJyW68FWRehC62TVIJeG3HFl5Qsg3AMUz0UEajvyyM bVresl/mOT5RkLO74c/3INadBxhN1LVXXyTioH9J6MfswNVeFHbFzupj3NGWBxqnsY O8niIP6YeNyWk6V4PZ/f+uFR/AXmo6H/MZegB6COwqBtZbgUaCZEb3VVJb5tBp/nu7 y+e3lIhYIFqwRwNQ4IPe1vTPwM6Ry4yf95i8zN7ALEM7LiEfdYVJwP/kHEnOd+Wgr7 4yRKQ9xdStmHQ== Date: Thu, 23 May 2019 16:14:27 +1000 From: Paul Mackerras To: Christophe Leroy Cc: Benjamin Herrenschmidt , Michael Ellerman , Nicholas Piggin , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v3 14/16] powerpc/32: implement fast entry for syscalls on BOOKE Message-ID: <20190523061427.GA19655@blackberry> References: <3e254178a157e7eaeef48f983880f71f97d1f296.1556627571.git.christophe.leroy@c-s.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3e254178a157e7eaeef48f983880f71f97d1f296.1556627571.git.christophe.leroy@c-s.fr> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 30, 2019 at 12:39:03PM +0000, Christophe Leroy wrote: > This patch implements a fast entry for syscalls. > > Syscalls don't have to preserve non volatile registers except LR. > > This patch then implement a fast entry for syscalls, where > volatile registers get clobbered. > > As this entry is dedicated to syscall it always sets MSR_EE > and warns in case MSR_EE was previously off > > It also assumes that the call is always from user, system calls are > unexpected from kernel. This is now upstream as commit 1a4b739bbb4f. On the e500mc test config that I use, I'm getting this build failure: arch/powerpc/kernel/head_fsl_booke.o: In function `SystemCall': arch/powerpc/kernel/head_fsl_booke.S:416: undefined reference to `kvmppc_handler_BOOKE_INTERRUPT_SYSCALL_SPRN_SRR1' Makefile:1052: recipe for target 'vmlinux' failed > +.macro SYSCALL_ENTRY trapno intno > + mfspr r10, SPRN_SPRG_THREAD > +#ifdef CONFIG_KVM_BOOKE_HV > +BEGIN_FTR_SECTION > + mtspr SPRN_SPRG_WSCRATCH0, r10 > + stw r11, THREAD_NORMSAVE(0)(r10) > + stw r13, THREAD_NORMSAVE(2)(r10) > + mfcr r13 /* save CR in r13 for now */ > + mfspr r11, SPRN_SRR1 > + mtocrf 0x80, r11 /* check MSR[GS] without clobbering reg */ > + bf 3, 1975f > + b kvmppc_handler_BOOKE_INTERRUPT_\intno\()_SPRN_SRR1 It seems to me that the "_SPRN_SRR1" on the end of this line isn't meant to be there... However, it still fails to link with that removed. Paul.