From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6095C282E1 for ; Thu, 23 May 2019 19:11:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5182218A2 for ; Thu, 23 May 2019 19:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558638719; bh=fcau2Na3AHGRaU+BsHdcB5iV/QDvQxU4OX8p2siQh4k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qCOZh6pNh1Me68d+npX2WyFirPAfiwr6Y6qb1KhJyfVtVV9gGBf9JDhJyRRudqsZ3 AuRg8m72OoN8zhIBVR3c7/TAKQiWHhcPUR+0m5H4G5KaliV1ovmHe/ZNXYs4XY0Zum RJPnNrs5inGzOj1v4VZUaYarR1ThXBlelqVpURRo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388332AbfEWTL6 (ORCPT ); Thu, 23 May 2019 15:11:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:45520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388313AbfEWTL4 (ORCPT ); Thu, 23 May 2019 15:11:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3B11E2133D; Thu, 23 May 2019 19:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558638715; bh=fcau2Na3AHGRaU+BsHdcB5iV/QDvQxU4OX8p2siQh4k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u8XXd5MflP/e0E1gA1J9PjgnCLhcShoWFG0xcWlKCEY5CYdkvwsfHiY2ufaCbag45 bOHeCOfKBCLTZZEQv+ZZzIluP6szRVQaorowX/0BC20xFIMhGMoS72O/rHeW095CLE jh1YTk4l9V13kvxnohj2TMKXL0Un7uQ+tbJjRnqo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Janusz Krzysztofik , Sakari Ailus , Mauro Carvalho Chehab Subject: [PATCH 4.14 21/77] media: ov6650: Fix sensor possibly not detected on probe Date: Thu, 23 May 2019 21:05:39 +0200 Message-Id: <20190523181723.252123464@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190523181719.982121681@linuxfoundation.org> References: <20190523181719.982121681@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Janusz Krzysztofik commit 933c1320847f5ed6b61a7d10f0a948aa98ccd7b0 upstream. After removal of clock_start() from before soc_camera_init_i2c() in soc_camera_probe() by commit 9aea470b399d ("[media] soc-camera: switch I2C subdevice drivers to use v4l2-clk") introduced in v3.11, the ov6650 driver could no longer probe the sensor successfully because its clock was no longer turned on in advance. The issue was initially worked around by adding that missing clock_start() equivalent to OMAP1 camera interface driver - the only user of this sensor - but a propoer fix should be rather implemented in the sensor driver code itself. Fix the issue by inserting a delay between the clock is turned on and the sensor I2C registers are read for the first time. Tested on Amstrad Delta with now out of tree but still locally maintained omap1_camera host driver. Fixes: 9aea470b399d ("[media] soc-camera: switch I2C subdevice drivers to use v4l2-clk") Signed-off-by: Janusz Krzysztofik Cc: stable@vger.kernel.org Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/i2c/ov6650.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/media/i2c/ov6650.c +++ b/drivers/media/i2c/ov6650.c @@ -826,6 +826,8 @@ static int ov6650_video_probe(struct i2c if (ret < 0) return ret; + msleep(20); + /* * check and show product ID and manufacturer ID */