From: Steven Rostedt <rostedt@goodmis.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: silence GCC 9 array bounds warning
Date: Thu, 23 May 2019 22:12:10 -0400 [thread overview]
Message-ID: <20190523221210.4a2bb326@oasis.local.home> (raw)
In-Reply-To: <20190523124535.GA12931@gmail.com>
On Thu, 23 May 2019 14:45:35 +0200
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
> +/*
> + * Reset the state of the trace_iterator so that it can read consumed data.
> + * Normally, the trace_iterator is used for reading the data when it is not
> + * consumed, and must retain state.
> + */
> +static __always_inline void trace_iterator_reset(struct trace_iterator *iter)
> +{
> + const size_t offset = offsetof(struct trace_iterator, seq);
> +
> + /*
> + * Keep gcc from complaining about overwriting more than just one
> + * member in the structure.
> + */
> + memset((char *)(iter) + offset, 0, sizeof(struct trace_iterator) - offset);
I still prefer the typecast of void *, as that's used a bit more in the
kernel, but since char * is also used (not as much), I'll leave it. But
the parenthesis around iter are unnecessary. I'll remove them.
-- Steve
> +
> + iter->pos = -1;
> +}
> +
next prev parent reply other threads:[~2019-05-24 2:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 12:45 [PATCH] tracing: silence GCC 9 array bounds warning Miguel Ojeda
2019-05-24 2:12 ` Steven Rostedt [this message]
2019-05-24 4:05 ` Miguel Ojeda
2019-05-24 11:52 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2019-05-17 9:25 Miguel Ojeda
2019-05-17 16:47 ` Steven Rostedt
2019-05-17 18:45 ` Miguel Ojeda
2019-05-17 17:59 ` Linus Torvalds
2019-05-17 19:09 ` Miguel Ojeda
2019-05-19 21:35 ` Steven Rostedt
2019-05-17 20:54 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523221210.4a2bb326@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).