From: Greg KH <gregkh@linuxfoundation.org>
To: Gen Zhang <blackgod016574@gmail.com>
Cc: jslaby@suse.com, keescook@chromium.org, khorenko@virtuozzo.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] consolemap: Fix a memory leaking bug in con_insert_unipair()
Date: Fri, 24 May 2019 10:02:00 +0200 [thread overview]
Message-ID: <20190524080200.GA19609@kroah.com> (raw)
In-Reply-To: <20190524021932.GA4866@zhanggen-UX430UQ>
On Fri, May 24, 2019 at 10:19:32AM +0800, Gen Zhang wrote:
> In function con_insert_unipair(), when allocation for p2 and p1[n]
> fails, ENOMEM is returned, but previously allocated p1 is not freed,
> remains as leaking memory. Thus we should free p1 as well when this
> allocation fails.
>
> Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Any reason you keep dropping me from this thread?
It's as if you don't want me to apply the patch :(
greg k-h
next prev parent reply other threads:[~2019-05-24 8:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 9:29 [PATCH] consolemap: Fix a memory leaking bug in drivers/tty/vt/consolemap.c Gen Zhang
2019-05-21 20:44 ` Kees Cook
2019-05-22 1:50 ` Gen Zhang
2019-05-22 20:54 ` Kees Cook
2019-05-23 0:29 ` Gen Zhang
2019-05-23 0:34 ` [PATCH v2] " Gen Zhang
2019-05-23 16:54 ` Kees Cook
2019-05-24 2:14 ` Gen Zhang
2019-05-24 2:19 ` [PATCH v2] consolemap: Fix a memory leaking bug in con_insert_unipair() Gen Zhang
2019-05-24 8:02 ` Greg KH [this message]
2019-05-24 9:37 ` [PATCH v2] consolemap: Fix a memory leaking bug in drivers/tty/vt/consolemap.c Jon Hunter
2019-05-25 6:04 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524080200.GA19609@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=blackgod016574@gmail.com \
--cc=jslaby@suse.com \
--cc=keescook@chromium.org \
--cc=khorenko@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).