From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <linux-kernel@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
<linux-media@vger.kernel.org>
Subject: Re: [PATCH next 15/25] media: platform: Use dev_get_drvdata()
Date: Fri, 24 May 2019 09:58:45 -0300 [thread overview]
Message-ID: <20190524095845.26ef82fd@coco.lan> (raw)
In-Reply-To: <20190423075020.173734-16-wangkefeng.wang@huawei.com>
Em Tue, 23 Apr 2019 15:50:10 +0800
Kefeng Wang <wangkefeng.wang@huawei.com> escreveu:
> Using dev_get_drvdata directly.
Patch looks ok to me. Assuming that this will be applied via some
other tree:
Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Benson Leung <bleung@chromium.org>
> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Cc: linux-media@vger.kernel.org
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/media/platform/cros-ec-cec/cros-ec-cec.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/cros-ec-cec/cros-ec-cec.c b/drivers/media/platform/cros-ec-cec/cros-ec-cec.c
> index 7bc4d8a9af28..2e218c7a3a1f 100644
> --- a/drivers/media/platform/cros-ec-cec/cros-ec-cec.c
> +++ b/drivers/media/platform/cros-ec-cec/cros-ec-cec.c
> @@ -174,8 +174,7 @@ static const struct cec_adap_ops cros_ec_cec_ops = {
> #ifdef CONFIG_PM_SLEEP
> static int cros_ec_cec_suspend(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct cros_ec_cec *cros_ec_cec = dev_get_drvdata(&pdev->dev);
> + struct cros_ec_cec *cros_ec_cec = dev_get_drvdata(dev);
>
> if (device_may_wakeup(dev))
> enable_irq_wake(cros_ec_cec->cros_ec->irq);
> @@ -185,8 +184,7 @@ static int cros_ec_cec_suspend(struct device *dev)
>
> static int cros_ec_cec_resume(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct cros_ec_cec *cros_ec_cec = dev_get_drvdata(&pdev->dev);
> + struct cros_ec_cec *cros_ec_cec = dev_get_drvdata(dev);
>
> if (device_may_wakeup(dev))
> disable_irq_wake(cros_ec_cec->cros_ec->irq);
Thanks,
Mauro
next prev parent reply other threads:[~2019-05-24 12:58 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 7:49 [PATCH next 00/25] cleanup: use dev_get_drvdata() directly Kefeng Wang
2019-04-23 7:49 ` [PATCH next 01/25] ACPI / DPTF: Use dev_get_drvdata() Kefeng Wang
2019-05-01 10:13 ` Rafael J. Wysocki
2019-04-23 7:49 ` [PATCH next 02/25] crypto: picoxcell: " Kefeng Wang
2019-05-03 6:09 ` Herbert Xu
2019-04-23 7:49 ` [PATCH next 03/25] dmaengine: " Kefeng Wang
2019-04-26 11:52 ` Vinod Koul
2019-04-28 4:00 ` [PATCH next v2 1/2] dmaengine: bcm-sba-raid: " Kefeng Wang
2019-04-28 4:00 ` [PATCH next v2 2/2] dmaengine: nbpfaxi: " Kefeng Wang
2019-04-29 5:17 ` [PATCH next v2 1/2] dmaengine: bcm-sba-raid: " Vinod Koul
2019-04-23 7:49 ` [PATCH next 04/25] drm/exynos: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 05/25] drm/msm: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 06/25] drm/omap: " Kefeng Wang
2019-05-28 10:57 ` Tomi Valkeinen
2019-04-23 7:50 ` [PATCH next 07/25] hwmon: s3c: " Kefeng Wang
2019-04-23 13:43 ` Guenter Roeck
2019-04-23 7:50 ` [PATCH next 08/25] iio: adc: at91: " Kefeng Wang
2019-04-27 12:07 ` Jonathan Cameron
2019-04-23 7:50 ` [PATCH next 09/25] input: keyboard: " Kefeng Wang
2019-04-23 8:44 ` Dmitry Torokhov
2019-04-23 7:50 ` [PATCH next 10/25] input: misc: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 11/25] input: mouse: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 12/25] input: touchscreen: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 13/25] iommu/omap: " Kefeng Wang
2019-04-26 14:49 ` Joerg Roedel
2019-04-23 7:50 ` [PATCH next 14/25] mailbox: bcm-flexrm-mailbox: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 15/25] media: platform: " Kefeng Wang
2019-05-24 12:58 ` Mauro Carvalho Chehab [this message]
2019-04-23 7:50 ` [PATCH next 16/25] mfd: " Kefeng Wang
2019-05-08 10:32 ` Lee Jones
2019-05-08 13:52 ` [PATCH next v2] " Kefeng Wang
2019-05-09 6:14 ` Lee Jones
2019-05-09 14:23 ` [PATCH next v3] " Kefeng Wang
2019-05-10 7:02 ` Lee Jones
2019-04-23 7:50 ` [PATCH next 17/25] mmc: omap_hsmmc: " Kefeng Wang
2019-04-29 10:45 ` Ulf Hansson
2019-04-23 7:50 ` [PATCH next 18/25] net: can: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 19/25] net: calxedaxgmac: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 20/25] platform/x86: asus-wmi: " Kefeng Wang
2019-05-06 9:01 ` Andy Shevchenko
2019-04-23 7:50 ` [PATCH next 21/25] rtc: " Kefeng Wang
2019-04-26 18:52 ` Alexandre Belloni
2019-04-23 7:50 ` [PATCH next 22/25] media: staging/imx7: " Kefeng Wang
2019-04-23 8:34 ` Rui Miguel Silva
2019-04-23 7:50 ` [PATCH next 23/25] thermal: " Kefeng Wang
2019-04-29 3:47 ` Zhang Rui
2019-04-29 6:55 ` Kefeng Wang
2019-04-23 7:50 ` [PATCH next 24/25] usb: musb: dsps: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 25/25] video: fbdev: " Kefeng Wang
2019-05-06 13:48 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524095845.26ef82fd@coco.lan \
--to=mchehab+samsung@kernel.org \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).