From: Gen Zhang <blackgod016574@gmail.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: agk@redhat.com, dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: dm-region-hash: fix a missing-check bug in __rh_alloc()
Date: Mon, 27 May 2019 11:12:51 +0800 [thread overview]
Message-ID: <20190527031251.GA18979@zhanggen-UX430UQ> (raw)
In-Reply-To: <20190527014913.GA10098@redhat.com>
On Sun, May 26, 2019 at 09:49:14PM -0400, Mike Snitzer wrote:
> On Sun, May 26 2019 at 8:50pm -0400,
> Gen Zhang <blackgod016574@gmail.com> wrote:
>
> > In function __rh_alloc(), the pointer nreg is allocated a memory space
> > via kmalloc(). And it is used in the following codes. However, when
> > there is a memory allocation error, kmalloc() fails. Thus null pointer
> > dereference may happen. And it will cause the kernel to crash. Therefore,
> > we should check the return value and handle the error.
> > Further, in __rh_find(), we should also check the return value and
> > handle the error.
> >
> > Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
> > ---
> > diff --git a/drivers/md/dm-region-hash.c b/drivers/md/dm-region-hash.c
> > index 1f76045..2fa1641 100644
> > --- a/drivers/md/dm-region-hash.c
> > +++ b/drivers/md/dm-region-hash.c
> > @@ -290,8 +290,11 @@ static struct dm_region *__rh_alloc(struct dm_region_hash *rh, region_t region)
> > struct dm_region *reg, *nreg;
> >
> > nreg = mempool_alloc(&rh->region_pool, GFP_ATOMIC);
> > - if (unlikely(!nreg))
> > + if (unlikely(!nreg)) {
> > nreg = kmalloc(sizeof(*nreg), GFP_NOIO | __GFP_NOFAIL);
> > + if (!nreg)
> > + return NULL;
> > + }
> >
> > nreg->state = rh->log->type->in_sync(rh->log, region, 1) ?
> > DM_RH_CLEAN : DM_RH_NOSYNC;
>
> This patch isn't needed. __GFP_NOFAIL means the allocation won't fail.
>
> And there are many other users of __GFP_NOFAIL that don't check for
> failure.
>
> Mike
Appreciate your reply, Mike.
Thanks
Gen
next prev parent reply other threads:[~2019-05-27 3:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 0:50 [PATCH] dm-region-hash: fix a missing-check bug in __rh_alloc() Gen Zhang
2019-05-27 1:49 ` Mike Snitzer
2019-05-27 3:12 ` Gen Zhang [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-05-24 3:12 [PATCH] dm-region-hash: Fix " Gen Zhang
2019-06-05 6:05 ` Jiri Slaby
2019-06-05 12:21 ` Mike Snitzer
2019-06-05 14:58 ` Gen Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527031251.GA18979@zhanggen-UX430UQ \
--to=blackgod016574@gmail.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).