From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0139DC07542 for ; Mon, 27 May 2019 09:59:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF3362175B for ; Mon, 27 May 2019 09:59:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726803AbfE0J7K (ORCPT ); Mon, 27 May 2019 05:59:10 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:40667 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbfE0J7K (ORCPT ); Mon, 27 May 2019 05:59:10 -0400 Received: from localhost (aaubervilliers-681-1-27-134.w90-88.abo.wanadoo.fr [90.88.147.134]) (Authenticated sender: maxime.ripard@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id AE932200014; Mon, 27 May 2019 09:59:07 +0000 (UTC) Date: Mon, 27 May 2019 11:59:07 +0200 From: Maxime Ripard To: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= Cc: Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Chen-Yu Tsai , linux-media@vger.kernel.org, devicetree , linux-arm-kernel , linux-kernel , linux-sunxi Subject: Re: [PATCH v2 02/10] media: rc: sunxi: Add A31 compatible Message-ID: <20190527095907.s2ubq3xos5hqef5p@flea> References: <20190526222536.10917-1-peron.clem@gmail.com> <20190526222536.10917-3-peron.clem@gmail.com> <20190527074700.rvhqua44ixudt52z@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="m4jzlbt2jcbegnyb" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --m4jzlbt2jcbegnyb Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 27, 2019 at 10:20:05AM +0200, Cl=E9ment P=E9ron wrote: > Hi Maxime, > > On Mon, 27 May 2019 at 09:47, Maxime Ripard w= rote: > > > > Hi, > > > > On Mon, May 27, 2019 at 12:25:28AM +0200, Cl=E9ment P=E9ron wrote: > > > Allwiner A31 has a different memory mapping so add the compatible > > > we will need it later. > > > > > > Signed-off-by: Cl=E9ment P=E9ron > > > --- > > > drivers/media/rc/sunxi-cir.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-ci= r.c > > > index 307e44714ea0..29ac33b68596 100644 > > > --- a/drivers/media/rc/sunxi-cir.c > > > +++ b/drivers/media/rc/sunxi-cir.c > > > @@ -319,6 +319,7 @@ static int sunxi_ir_remove(struct platform_device= *pdev) > > > static const struct of_device_id sunxi_ir_match[] =3D { > > > { .compatible =3D "allwinner,sun4i-a10-ir", }, > > > { .compatible =3D "allwinner,sun5i-a13-ir", }, > > > + { .compatible =3D "allwinner,sun6i-a31-ir", }, > > > > We should also move from reset_get_optional to the non optional > > variant for the A31, and ignore it otherwise. > > Should this be done in this series ? Yep, please Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --m4jzlbt2jcbegnyb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXOu06wAKCRDj7w1vZxhR xT6eAP9HYOS4/YL7nDIyH8X1cRrNbqpJMWDjdFnOep5zfx8jjwD/Qcw/3E8rl/S+ gHsm5kr92Rx4StTFdWA00FbyFkAjMQU= =xrzq -----END PGP SIGNATURE----- --m4jzlbt2jcbegnyb--