From: Valentin Schneider <valentin.schneider@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org
Subject: [PATCH RESEND 7/7] sh64: entry: Remove unneeded need_resched() loop
Date: Tue, 28 May 2019 11:48:48 +0100 [thread overview]
Message-ID: <20190528104848.13160-8-valentin.schneider@arm.com> (raw)
In-Reply-To: <20190528104848.13160-1-valentin.schneider@arm.com>
Since the enabling and disabling of IRQs within preempt_schedule_irq()
is contained in a need_resched() loop, we don't need the outer arch
code loop.
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: linux-sh@vger.kernel.org
---
arch/sh/kernel/cpu/sh5/entry.S | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/sh/kernel/cpu/sh5/entry.S b/arch/sh/kernel/cpu/sh5/entry.S
index de68ffdfffbf..40e6d9a7a6a2 100644
--- a/arch/sh/kernel/cpu/sh5/entry.S
+++ b/arch/sh/kernel/cpu/sh5/entry.S
@@ -897,7 +897,6 @@ resume_kernel:
ld.l r6, TI_PRE_COUNT, r7
beq/u r7, ZERO, tr0
-need_resched:
ld.l r6, TI_FLAGS, r7
movi (1 << TIF_NEED_RESCHED), r8
and r8, r7, r8
@@ -911,9 +910,7 @@ need_resched:
ori r7, 1, r7
ptabs r7, tr1
blink tr1, LINK
-
- pta need_resched, tr1
- blink tr1, ZERO
+ blink tr0, ZERO
#endif
.global ret_from_syscall
--
2.20.1
prev parent reply other threads:[~2019-05-28 10:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 10:48 [PATCH RESEND 0/7] entry: preempt_schedule_irq() callers scrub Valentin Schneider
2019-05-28 10:48 ` [PATCH RESEND 1/7] sched/core: Fix preempt_schedule() interrupt return comment Valentin Schneider
2019-05-28 10:58 ` Valentin Schneider
2019-06-11 19:30 ` Thomas Gleixner
2019-05-28 10:48 ` [PATCH RESEND 2/7] csky: entry: Remove unneeded need_resched() loop Valentin Schneider
2019-05-29 1:48 ` Guo Ren
2019-05-28 10:48 ` [PATCH RESEND 3/7] h8300: " Valentin Schneider
2019-05-28 10:48 ` [PATCH RESEND 4/7] microblaze: " Valentin Schneider
2019-05-28 10:48 ` [PATCH RESEND 5/7] RISC-V: " Valentin Schneider
2019-05-30 4:09 ` Palmer Dabbelt
2019-05-30 16:37 ` Valentin Schneider
2019-05-28 10:48 ` [PATCH RESEND 6/7] sh: " Valentin Schneider
2019-05-28 10:48 ` Valentin Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528104848.13160-8-valentin.schneider@arm.com \
--to=valentin.schneider@arm.com \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).