From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Oleksandr Tyshchenko <olekstysh@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Julien Grall <julien.grall@arm.com>,
Magnus Damm <magnus.damm@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: Re: [PATCH V5] ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available
Date: Tue, 28 May 2019 18:05:09 +0200 [thread overview]
Message-ID: <20190528160509.5vunuxxxcjduobpb@verge.net.au> (raw)
In-Reply-To: <CAMuHMdVC=aNQTZ0r+7qpiWEyEaoQ587pm1FxhWqR3pwHwv2ARg@mail.gmail.com>
On Tue, May 28, 2019 at 10:27:56AM +0200, Geert Uytterhoeven wrote:
> Hi Oleksandr,
>
> On Fri, May 17, 2019 at 11:58 AM Oleksandr Tyshchenko
> <olekstysh@gmail.com> wrote:
> > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >
> > If PSCI is available then most likely we are running on PSCI-enabled
> > U-Boot which, we assume, has already taken care of resetting CNTVOFF
> > and updating counter module before switching to non-secure mode
> > and we don't need to.
> >
> > As the psci_smp_available() helper always returns false if CONFIG_SMP
> > is disabled, it can't be used safely as an indicator of PSCI usage.
> > For that reason, we check for the mandatory PSCI operation to be
> > available.
> >
> > Please note, an extra check to prevent secure_cntvoff_init() from
> > being called for secondary CPUs in headsmp-apmu.S is not needed,
> > as SMP code for APMU based system is not executed if PSCI is in use.
> >
> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> > Changes in v5:
> > - Check for psci_ops.cpu_on if CONFIG_ARM_PSCI_FW is defined
>
> Thanks for the update!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Two cosmetic comments below. I'll leave it to Simon to ignore them for
> applying ;-)
Oleksandr, could I trouble you to respin with the
changes suggested by Geert?
>
> > @@ -62,6 +63,21 @@ void __init rcar_gen2_timer_init(void)
> > {
> > void __iomem *base;
> > u32 freq;
> > + bool need_update = true;
>
> Some people like reverse Xmas tree declaration order...
>
> > +
> > + /*
> > + * If PSCI is available then most likely we are running on PSCI-enabled
> > + * U-Boot which, we assume, has already taken care of resetting CNTVOFF
> > + * and updating counter module before switching to non-secure mode
> > + * and we don't need to.
> > + */
> > +#if defined(CONFIG_ARM_PSCI_FW)
>
> #ifdef CONFIG_ARM_PSCI_FW ?
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
next prev parent reply other threads:[~2019-05-28 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 9:58 [PATCH V5] ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available Oleksandr Tyshchenko
2019-05-24 9:39 ` Oleksandr
2019-05-28 8:27 ` Geert Uytterhoeven
2019-05-28 10:10 ` Oleksandr
2019-05-28 16:05 ` Simon Horman [this message]
2019-05-28 16:17 ` Oleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528160509.5vunuxxxcjduobpb@verge.net.au \
--to=horms@verge.net.au \
--cc=geert@linux-m68k.org \
--cc=julien.grall@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=olekstysh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).