From: Matthias Kaehlcke <mka@chromium.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
briannorris@chromium.org, ryandcase@chromium.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: rockchip: Add pin names for rk3288-veyron jaq, mickey, speedy
Date: Tue, 28 May 2019 13:29:47 -0700 [thread overview]
Message-ID: <20190528202947.GL40515@google.com> (raw)
In-Reply-To: <20190524233309.45420-1-dianders@chromium.org>
On Fri, May 24, 2019 at 04:33:09PM -0700, Douglas Anderson wrote:
> This is like commit 0ca87bd5baa6 ("ARM: dts: rockchip: Add pin names
> for rk3288-veyron-jerry") and commit ca3516b32cd9 ("ARM: dts:
> rockchip: Add pin names for rk3288-veyron-minnie") but for 3 more
> veyron boards.
>
> A few notes:
> - While there is most certainly duplication between all the veyron
> boards, it still feels like it is sane to just have each board have
> a full list of its pin names. The format of "gpio-line-names" does
> not lend itself to one-off overriding and besides it seems sane to
> more fully match schematic names. Also note that the extra
> duplication here is only in source code and is unlikely to ever
> change (since these boards are shipped). Duplication in the .dtb
> files is unavoidable.
> - veyron-jaq and veyron-mighty are very closely related and so I have
> shared a single list for them both with comments on how they are
> different. This is just a typo fix on one of the boards, a possible
> missing signal on one of the boards (or perhaps I was never given
> the most recent schematics?) and dealing with the fact that one of
> the two boards has full sized SD.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org
next prev parent reply other threads:[~2019-05-28 20:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 23:33 [PATCH] ARM: dts: rockchip: Add pin names for rk3288-veyron jaq, mickey, speedy Douglas Anderson
2019-05-28 20:29 ` Matthias Kaehlcke [this message]
2019-06-04 14:14 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528202947.GL40515@google.com \
--to=mka@chromium.org \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ryandcase@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).