From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8E94C28CC2 for ; Wed, 29 May 2019 16:37:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B261F23DE7 for ; Wed, 29 May 2019 16:37:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="HzpC0qmw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726892AbfE2Qhn (ORCPT ); Wed, 29 May 2019 12:37:43 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:33169 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726097AbfE2Qhn (ORCPT ); Wed, 29 May 2019 12:37:43 -0400 Received: by mail-pf1-f193.google.com with SMTP id z28so1993113pfk.0 for ; Wed, 29 May 2019 09:37:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rYXje7pkSQOlawqAWE5SmLuc60hKf0FafMLhT40aro4=; b=HzpC0qmw+hi+wxNs0qM40dFyonuMi7Bwb2k+tFbOesTzBeZBOfDBx0+EAkrAoZCUHw XYtC7TeTj/1vIUxlmgGzB1AhFFhRBsE+jMIH6a3R5WIAFYvzuLhSBnp/IEEQBkZ5e/ek WsQz9YWMWQn+K6ij5Yj5irLOe4DGrjvwRUsI5aK7JHVo0QFgzLQvCKcpAIWAN6s98P8m 0SYsWPVf0/IuQKFxW4LajOrGMRv+AVFbjaGYwdkJ9EpLTu0A4m+taaOAyVV1IhNAUzeI PtJG1T4XS5PhwlMeW4/sVsCIzxLxsZVwqLOXB+WnjakWX9il7Nyt4L5cDR/UsZcLJKhD MdrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rYXje7pkSQOlawqAWE5SmLuc60hKf0FafMLhT40aro4=; b=eKi9R+Ltqd4P9jlLcSgmJe4tmo4htPBNn8Z9nagefO2zVf2JIIJ7ep2cR8lTPya6h6 B5+vv0NuXMwf8hQdCot7LdjBpGAYHZihJXXK+I3eEuXNgJ2XaJr2qCJ9kykQg2FgQpq/ kygPYQXZG/yGUeppqlhmdr+h/ijcpBToRslXlHl1FgAKMPmbYwPGK7QsYrsEtTTk/hrB ACMoBOO39bJ6F85K99IbR/cOK15diW88+938hO5UoXf9Pd4xWrJC3tqXmJgfRCCwzd0/ sxwbn4eiiujgHq5Hops//3uw/TMteYOhH/5m4KPkx1AOOLg1xMVi31cqU8EJVyIxQOmY /PYg== X-Gm-Message-State: APjAAAVwfGJRjoIXmZqg6llTUjM8QqFwDHiKhMCqxyBWHqCZhOB41f3X izN3zQMTVR7iQX8w2/l45BPy+A== X-Google-Smtp-Source: APXvYqyxEAEh9Ml0eSaDbqfzNPYl7K6SJN3kxuzDOeDcbyjeiHXPApREIkOKRA2MpiLkXWFsDvT14A== X-Received: by 2002:a62:1846:: with SMTP id 67mr132559052pfy.33.1559147862067; Wed, 29 May 2019 09:37:42 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d24sm45802pjv.24.2019.05.29.09.37.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 May 2019 09:37:41 -0700 (PDT) Date: Wed, 29 May 2019 09:35:48 -0700 From: Stephen Hemminger To: Eric Dumazet Cc: Paul Menzel , Eric Dumazet , Jeff Kirsher , intel-wired-lan@lists.osuosl.org, netdev , Linux Kernel Mailing List Subject: Re: Driver has suspect GRO implementation, TCP performance may be compromised. Message-ID: <20190529093548.3df7ee73@hermes.lan> In-Reply-To: References: <8627ea1e-8e51-c425-97f6-aeb57176e11a@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 May 2019 09:00:54 -0700 Eric Dumazet wrote: > On Wed, May 29, 2019 at 7:49 AM Paul Menzel wrote: > > > > Dear Eric, > > > > > > Thank you for the quick reply. > > > > On 05/28/19 19:18, Eric Dumazet wrote: > > > On 5/28/19 8:42 AM, Paul Menzel wrote: > > > > >> Occasionally, Linux outputs the message below on the workstation Dell > > >> OptiPlex 5040 MT. > > >> > > >> TCP: net00: Driver has suspect GRO implementation, TCP performance may be compromised. > > >> > > >> Linux 4.14.55 and Linux 5.2-rc2 show the message, and the WWW also > > >> gives some hits [1][2]. > > >> > > >> ``` > > >> $ sudo ethtool -i net00 > > >> driver: e1000e > > >> version: 3.2.6-k > > >> firmware-version: 0.8-4 > > >> expansion-rom-version: > > >> bus-info: 0000:00:1f.6 > > >> supports-statistics: yes > > >> supports-test: yes > > >> supports-eeprom-access: yes > > >> supports-register-dump: yes > > >> supports-priv-flags: no > > >> ``` > > >> > > >> Can the driver e1000e be improved? > > >> > > >> Any idea, what triggers this, as I do not see it every boot? Download > > >> of big files? > > >> > > > Maybe the driver/NIC can receive frames bigger than MTU, although this would be strange. > > > > > > diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c > > > index c61edd023b352123e2a77465782e0d32689e96b0..cb0194f66125bcba427e6e7e3cacf0c93040ef61 100644 > > > --- a/net/ipv4/tcp_input.c > > > +++ b/net/ipv4/tcp_input.c > > > @@ -150,8 +150,10 @@ static void tcp_gro_dev_warn(struct sock *sk, const struct sk_buff *skb, > > > rcu_read_lock(); > > > dev = dev_get_by_index_rcu(sock_net(sk), skb->skb_iif); > > > if (!dev || len >= dev->mtu) > > > - pr_warn("%s: Driver has suspect GRO implementation, TCP performance may be compromised.\n", > > > - dev ? dev->name : "Unknown driver"); > > > + pr_warn("%s: Driver has suspect GRO implementation, TCP performance may be compromised." > > > + " len %u mtu %u\n", > > > + dev ? dev->name : "Unknown driver", > > > + len, dev ? dev->mtu : 0); > > > rcu_read_unlock(); > > > } > > > } > > > > I applied your patch on commit 9fb67d643 (Merge tag 'pinctrl-v5.2-2' of > > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl): > > > > [ 5507.291769] TCP: net00: Driver has suspect GRO implementation, TCP performance may be compromised. len 1856 mtu 1500 > > > The 'GRO' in the warning can be probably ignored, since this NIC does > not implement its own GRO. > > You can confirm this with this debug patch: > > diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c > b/drivers/net/ethernet/intel/e1000e/netdev.c > index 0e09bede42a2bd2c912366a68863a52a22def8ee..014a43ce77e09664bda0568dd118064b006acd67 > 100644 > --- a/drivers/net/ethernet/intel/e1000e/netdev.c > +++ b/drivers/net/ethernet/intel/e1000e/netdev.c > @@ -561,6 +561,9 @@ static void e1000_receive_skb(struct e1000_adapter *adapter, > if (staterr & E1000_RXD_STAT_VP) > __vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), tag); > > + if (skb->len > netdev->mtu) > + pr_err_ratelimited("received packet bigger (%u) than > MTU (%u)\n", > + skb->len, netdev->mtu); > napi_gro_receive(&adapter->napi, skb); > } I think e1000 is one of those devices that only has receive limit as power of 2. Therefore frames up to 2K can be received. There always some confusion in Linux about whether MTU is transmit only or devices have to enforce it on receive.