From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA06DC28CC2 for ; Wed, 29 May 2019 18:48:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97EF9240AD for ; Wed, 29 May 2019 18:48:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559155720; bh=AHC2B0Mx8E7VfpBekFB21lf/IxFld+6/D+1fIfurU3E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2u7j0VBNTFdZKx2gtZKSXAuLjkguKddSt5bKKjYN7U4k7kDOHA/z1veHJYHcMjSGP BI0IXkUQiTGk/mpO+82dmb4d2arepkHZQLWSnCuBdwBdhRfhCkbreAxJNnmAmYSL00 kGTNMm8QoLfJgZviDAQRn7Mn34p3xGwSF+jFv4iU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726723AbfE2Ssk (ORCPT ); Wed, 29 May 2019 14:48:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:38576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbfE2Ssj (ORCPT ); Wed, 29 May 2019 14:48:39 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D9A40240AC; Wed, 29 May 2019 18:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559155719; bh=AHC2B0Mx8E7VfpBekFB21lf/IxFld+6/D+1fIfurU3E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yznERW92LTkHlXto/cGkoOxVVDbFeYyNCibZEPWZR0KU5KLEdtjuI8zOq4MiNJ6mw XzKg+NPMNQt4lF0I+v+YfsJg/mTMn2eZOHkA7T17DnMWt09ptRsdB6cMBC8a4N3FdT k48i4ZMPppiLRFatkZ1tTDisb1Kv2vEmKMSbS+3s= Date: Wed, 29 May 2019 14:48:37 -0400 From: Sasha Levin To: Stefan Bader Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Eric Dumazet , Peter Oskolkov , Florian Westphal , "David S . Miller" , netdev@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.1 011/375] ip6: fix skb leak in ip6frag_expire_frag_queue() Message-ID: <20190529184837.GF12898@sasha-vm> References: <20190522192115.22666-1-sashal@kernel.org> <20190522192115.22666-11-sashal@kernel.org> <1036ddff-720f-ad5b-dbc0-2d4ad4de0392@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1036ddff-720f-ad5b-dbc0-2d4ad4de0392@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 23, 2019 at 09:47:23AM +0200, Stefan Bader wrote: >On 22.05.19 21:15, Sasha Levin wrote: >> From: Eric Dumazet >> >> [ Upstream commit 47d3d7fdb10a21c223036b58bd70ffdc24a472c4 ] >> >> Since ip6frag_expire_frag_queue() now pulls the head skb >> from frag queue, we should no longer use skb_get(), since >> this leads to an skb leak. >> >> Stefan Bader initially reported a problem in 4.4.stable [1] caused >> by the skb_get(), so this patch should also fix this issue. > >Just to let everybody know, while changing this has fixed the BUG_ON problem >while sending (in 4.4) it now crashes when releasing just a little later. >Still feels like the right direction but not complete, yet. mhm, this commit is really under David's domain, it squeezed through my filters as it doesn't actually touch net/. I'll drop it for now. -- Thanks, Sasha