From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A9AEC46460 for ; Thu, 30 May 2019 14:54:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64A9925BC3 for ; Thu, 30 May 2019 14:54:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727330AbfE3Oyi (ORCPT ); Thu, 30 May 2019 10:54:38 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:37898 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725934AbfE3Oyi (ORCPT ); Thu, 30 May 2019 10:54:38 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E4E37341; Thu, 30 May 2019 07:54:37 -0700 (PDT) Received: from redmoon (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D51E43F59C; Thu, 30 May 2019 07:54:36 -0700 (PDT) Date: Thu, 30 May 2019 15:54:31 +0100 From: Lorenzo Pieralisi To: Ley Foon Tan Cc: Ley Foon Tan , Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-pci Subject: Re: [PATCH] PCI: altera: Fix no return warning for altera_pcie_irq_teardown() Message-ID: <20190530145411.GA13993@redmoon> References: <1558664151-2584-1-git-send-email-ley.foon.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 24, 2019 at 10:17:28AM +0800, Ley Foon Tan wrote: > On Fri, May 24, 2019 at 10:15 AM Ley Foon Tan wrote: > > > > Fix compilation warning caused by patch "PCI: altera: Allow building as module". > > > > drivers/pci/controller/pcie-altera.c: In function ‘altera_pcie_irq_teardown’: > > drivers/pci/controller/pcie-altera.c:723:1: warning: no return statement in function returning non-void [-Wreturn-type] > > } > > > > Signed-off-by: Ley Foon Tan > > --- > > drivers/pci/controller/pcie-altera.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-altera.c > > index 6c86bc69ace8..27222071ace7 100644 > > --- a/drivers/pci/controller/pcie-altera.c > > +++ b/drivers/pci/controller/pcie-altera.c > > @@ -706,7 +706,7 @@ static int altera_pcie_init_irq_domain(struct altera_pcie *pcie) > > return 0; > > } > > > > -static int altera_pcie_irq_teardown(struct altera_pcie *pcie) > > +static void altera_pcie_irq_teardown(struct altera_pcie *pcie) > > { > > irq_set_chained_handler_and_data(pcie->irq, NULL, NULL); > > irq_domain_remove(pcie->irq_domain); > > -- > > 2.19.0 > > > Hi > > You can squash this patch to this https://lkml.org/lkml/2019/4/24/18 > "PCI: altera: Allow building as module" if want. Done, thanks. Lorenzo