From: Minchan Kim <minchan@kernel.org> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, linux-api@vger.kernel.org, Michal Hocko <mhocko@suse.com>, Johannes Weiner <hannes@cmpxchg.org>, Tim Murray <timmurray@google.com>, Joel Fernandes <joel@joelfernandes.org>, Suren Baghdasaryan <surenb@google.com>, Daniel Colascione <dancol@google.com>, Shakeel Butt <shakeelb@google.com>, Sonny Rao <sonnyrao@google.com>, Brian Geffon <bgeffon@google.com>, jannh@google.com, oleg@redhat.com, christian@brauner.io, oleksandr@redhat.com, hdanton@sina.com, Minchan Kim <minchan@kernel.org> Subject: [RFCv2 2/6] mm: change PAGEREF_RECLAIM_CLEAN with PAGE_REFRECLAIM Date: Fri, 31 May 2019 15:43:09 +0900 Message-ID: <20190531064313.193437-3-minchan@kernel.org> (raw) In-Reply-To: <20190531064313.193437-1-minchan@kernel.org> The local variable references in shrink_page_list is PAGEREF_RECLAIM_CLEAN as default. It is for preventing to reclaim dirty pages when CMA try to migrate pages. Strictly speaking, we don't need it because CMA didn't allow to write out by .may_writepage = 0 in reclaim_clean_pages_from_list. Moreover, it has a problem to prevent anonymous pages's swap out even though force_reclaim = true in shrink_page_list on upcoming patch. So this patch makes references's default value to PAGEREF_RECLAIM and rename force_reclaim with ignore_references to make it more clear. This is a preparatory work for next patch. * RFCv1 * use ignore_referecnes as parameter name - hannes Acked-by: Johannes Weiner <hannes@cmpxchg.org> Signed-off-by: Minchan Kim <minchan@kernel.org> --- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 84dcb651d05c..0973a46a0472 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1102,7 +1102,7 @@ static unsigned long shrink_page_list(struct list_head *page_list, struct scan_control *sc, enum ttu_flags ttu_flags, struct reclaim_stat *stat, - bool force_reclaim) + bool ignore_references) { LIST_HEAD(ret_pages); LIST_HEAD(free_pages); @@ -1116,7 +1116,7 @@ static unsigned long shrink_page_list(struct list_head *page_list, struct address_space *mapping; struct page *page; int may_enter_fs; - enum page_references references = PAGEREF_RECLAIM_CLEAN; + enum page_references references = PAGEREF_RECLAIM; bool dirty, writeback; unsigned int nr_pages; @@ -1247,7 +1247,7 @@ static unsigned long shrink_page_list(struct list_head *page_list, } } - if (!force_reclaim) + if (!ignore_references) references = page_check_references(page, sc); switch (references) { -- 2.22.0.rc1.257.g3120a18244-goog
next prev parent reply index Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-31 6:43 [RFCv2 0/6] introduce memory hinting API for external process Minchan Kim 2019-05-31 6:43 ` [RFCv2 1/6] mm: introduce MADV_COLD Minchan Kim 2019-05-31 8:47 ` Michal Hocko 2019-05-31 13:39 ` Minchan Kim 2019-05-31 14:03 ` Michal Hocko 2019-05-31 14:34 ` Minchan Kim 2019-06-03 7:16 ` Michal Hocko 2019-06-03 15:43 ` Daniel Colascione 2019-06-03 17:27 ` Johannes Weiner 2019-06-03 20:32 ` Michal Hocko 2019-06-03 21:50 ` Johannes Weiner 2019-06-03 23:02 ` Minchan Kim 2019-06-04 6:56 ` Michal Hocko 2019-06-04 12:06 ` Johannes Weiner 2019-06-04 6:55 ` Michal Hocko 2019-06-04 4:26 ` Minchan Kim 2019-06-04 7:02 ` Michal Hocko 2019-05-31 6:43 ` Minchan Kim [this message] 2019-05-31 6:43 ` [RFCv2 3/6] mm: introduce MADV_PAGEOUT Minchan Kim 2019-05-31 8:50 ` Michal Hocko 2019-05-31 13:44 ` Minchan Kim 2019-05-31 16:59 ` Johannes Weiner 2019-05-31 23:14 ` Minchan Kim 2019-05-31 6:43 ` [RFCv2 4/6] mm: factor out madvise's core functionality Minchan Kim 2019-05-31 7:04 ` Oleksandr Natalenko 2019-05-31 13:12 ` Minchan Kim 2019-05-31 14:35 ` Oleksandr Natalenko 2019-05-31 23:29 ` Minchan Kim 2019-06-05 13:27 ` Oleksandr Natalenko 2019-06-10 10:12 ` Minchan Kim 2019-05-31 6:43 ` [RFCv2 5/6] mm: introduce external memory hinting API Minchan Kim 2019-05-31 8:37 ` Michal Hocko 2019-05-31 13:19 ` Minchan Kim 2019-05-31 14:00 ` Michal Hocko 2019-05-31 14:11 ` Minchan Kim 2019-05-31 17:35 ` Daniel Colascione 2019-05-31 6:43 ` [RFCv2 6/6] mm: extend process_madvise syscall to support vector arrary Minchan Kim 2019-05-31 10:06 ` Yann Droneaud 2019-05-31 23:18 ` Minchan Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190531064313.193437-3-minchan@kernel.org \ --to=minchan@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=bgeffon@google.com \ --cc=christian@brauner.io \ --cc=dancol@google.com \ --cc=hannes@cmpxchg.org \ --cc=hdanton@sina.com \ --cc=jannh@google.com \ --cc=joel@joelfernandes.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.com \ --cc=oleg@redhat.com \ --cc=oleksandr@redhat.com \ --cc=shakeelb@google.com \ --cc=sonnyrao@google.com \ --cc=surenb@google.com \ --cc=timmurray@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git