From: Shawn Guo <shawnguo@kernel.org>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
Anson Huang <anson.huang@nxp.com>,
"S.j. Wang" <shengjiu.wang@nxp.com>, Peng Fan <peng.fan@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"m.felsch@pengutronix.de" <m.felsch@pengutronix.de>
Subject: Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524
Date: Fri, 31 May 2019 15:28:33 +0800 [thread overview]
Message-ID: <20190531072832.GC23453@dragon> (raw)
In-Reply-To: <CAEnQRZD98TKduVLshGrBANRB6NT7Se6CXD0cgd5XRYa6grAo4Q@mail.gmail.com>
On Tue, May 28, 2019 at 10:10:43AM +0300, Daniel Baluta wrote:
> On Mon, May 20, 2019 at 10:33 PM Fabio Estevam <festevam@gmail.com> wrote:
> >
> > On Thu, May 16, 2019 at 3:35 PM Fabio Estevam <festevam@gmail.com> wrote:
> > >
> > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta <daniel.baluta@nxp.com> wrote:
> > >
> > > > + simple-audio-card,codec {
> > > > + sound-dai = <&wm8524>;
> > > > + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>;
> > >
> > > IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3
> > > interface, not an external clock that feeds the codec.
> > >
> > > It seems you should remove this 'clocks' entry.
> >
> > Just checked the schematics and the SAI3_MCLK pin clocks the codec, so
> > the representation is correct:
> >
> > Reviewed-by: Fabio Estevam <festevam@gmail.com>
>
> Shawn,
>
> Can you have a look?
I cannot apply this one, because there are '=20' in the patch content.
Shawn
next prev parent reply other threads:[~2019-05-31 7:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 14:42 [RESEND PATCH v3 0/2] Enable wm8524 codec on i.MX8MM EVK Daniel Baluta
2019-05-15 14:42 ` [PATCH v3 1/2] arm64: dts: imx8mm: Add SAI nodes Daniel Baluta
2019-05-16 18:33 ` Fabio Estevam
2019-05-20 19:33 ` Fabio Estevam
2019-05-31 7:27 ` Shawn Guo
2019-05-15 14:42 ` [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 Daniel Baluta
2019-05-16 18:35 ` Fabio Estevam
2019-05-20 10:12 ` Daniel Baluta
2019-05-20 19:34 ` Fabio Estevam
2019-05-20 19:32 ` Fabio Estevam
2019-05-28 7:10 ` Daniel Baluta
2019-05-31 7:28 ` Shawn Guo [this message]
2019-05-31 7:42 ` Shawn Guo
-- strict thread matches above, loose matches on Subject: below --
2019-04-24 15:04 [PATCH v3 0/2] Enable wm8524 codec on i.MX8MM EVK Daniel Baluta
2019-04-24 15:04 ` [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531072832.GC23453@dragon \
--to=shawnguo@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=daniel.baluta@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).