From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F6FCC04AB6 for ; Fri, 31 May 2019 07:43:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 431A82652C for ; Fri, 31 May 2019 07:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559288634; bh=BSO7PBA+ISSFwY87NDWyqZN2RLuI6E2nd55J5EJjfrI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QKHPBPTWKOZH923D/sGqhRmdrFRecOgW2bOeIpmpRUnbWv0tEHv5YMTWJoalQ0eJT tp7tgD/eQ1rD9xt233hmFP2qZre+q4vfwgTJawggnkRr08MD242i3cE9CDts/P08iD A3qrdMlAIAjlt6tHSgXeT1TDqI40qKn43tHAGjps= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726916AbfEaHnx (ORCPT ); Fri, 31 May 2019 03:43:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:47046 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726275AbfEaHnx (ORCPT ); Fri, 31 May 2019 03:43:53 -0400 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F29326529; Fri, 31 May 2019 07:43:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559288632; bh=BSO7PBA+ISSFwY87NDWyqZN2RLuI6E2nd55J5EJjfrI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GA2IoBIQOegjFScrFondeK8spRXBSFymW1AP9qrLJiol9hWRMym9scSnEGDwSQ8Ph MKJzxigCFNwwje/M9U6IfeYm4Ld7G6r/+mgEaLxUdrQ35KGWQ+aIHTsR+g0w1YgmmT NJncQZ5TTpXzdQvUMVqy7ResQtMsJPrhJAlhQiO4= Date: Fri, 31 May 2019 15:42:30 +0800 From: Shawn Guo To: Daniel Baluta Cc: "mark.rutland@arm.com" , Aisheng Dong , Peng Fan , Anson Huang , "devicetree@vger.kernel.org" , Fabio Estevam , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "m.felsch@pengutronix.de" , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , Daniel Baluta , "S.j. Wang" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 Message-ID: <20190531074230.GE23453@dragon> References: <20190515144210.25596-1-daniel.baluta@nxp.com> <20190515144210.25596-3-daniel.baluta@nxp.com> <20190531072832.GC23453@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190531072832.GC23453@dragon> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 31, 2019 at 03:28:33PM +0800, Shawn Guo wrote: > On Tue, May 28, 2019 at 10:10:43AM +0300, Daniel Baluta wrote: > > On Mon, May 20, 2019 at 10:33 PM Fabio Estevam wrote: > > > > > > On Thu, May 16, 2019 at 3:35 PM Fabio Estevam wrote: > > > > > > > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta wrote: > > > > > > > > > + simple-audio-card,codec { > > > > > + sound-dai = <&wm8524>; > > > > > + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>; > > > > > > > > IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3 > > > > interface, not an external clock that feeds the codec. > > > > > > > > It seems you should remove this 'clocks' entry. > > > > > > Just checked the schematics and the SAI3_MCLK pin clocks the codec, so > > > the representation is correct: > > > > > > Reviewed-by: Fabio Estevam > > > > Shawn, > > > > Can you have a look? > > I cannot apply this one, because there are '=20' in the patch content. Talk to NXP colleague Anson Huang to find out how to fix it. https://patchwork.kernel.org/patch/10944169/#22656941 Shawn