From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Spyridon Papageorgiou <spapageorgiou@de.adit-jv.com>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Tobias Franzen <tfranzen@de.adit-jv.com>,
Biju Das <biju.das@bp.renesas.com>
Subject: Re: [PATCH] arm64: dts: ulcb-kf: Add support for TI WL1837
Date: Fri, 31 May 2019 11:37:02 +0200 [thread overview]
Message-ID: <20190531093702.4pdbamghomqdhhuq@verge.net.au> (raw)
In-Reply-To: <CAMuHMdVfDd_1gHnX=WvkHnF33fG2sWy7F5bTh-DghoKSt-vLCA@mail.gmail.com>
Hi Spyridon,
please respond to Geert's review below and
if appropriate provide an incremental patch.
Thanks in advance,
Simon
On Tue, May 28, 2019 at 11:19:04AM +0200, Geert Uytterhoeven wrote:
> Hi Spyridon,
>
> On Thu, Apr 11, 2019 at 2:42 PM Spyridon Papageorgiou
> <spapageorgiou@de.adit-jv.com> wrote:
> > This patch adds description of TI WL1837 and links interfaces
> > to communicate with the IC, namely the SDIO interface to WLAN.
> >
> > Signed-off-by: Spyridon Papageorgiou <spapageorgiou@de.adit-jv.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> > @@ -38,6 +38,18 @@
> > regulator-min-microvolt = <5000000>;
> > regulator-max-microvolt = <5000000>;
> > };
> > +
> > + wlan_en: regulator-wlan_en {
> > + compatible = "regulator-fixed";
> > + regulator-name = "wlan-en-regulator";
> > +
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
>
> So this is a 3.3V regulator...
>
> > +
> > + gpio = <&gpio_exp_74 4 GPIO_ACTIVE_HIGH>;
> > + startup-delay-us = <70000>;
> > + enable-active-high;
> > + };
> > };
> >
> > &can0 {
>
> > @@ -273,6 +298,30 @@
> > status = "okay";
> > };
> >
> > +&sdhi3 {
> > + pinctrl-0 = <&sdhi3_pins>;
> > + pinctrl-names = "default";
> > +
> > + vmmc-supply = <&wlan_en>;
> > + vqmmc-supply = <&wlan_en>;
>
> ... used for both card and I/O line power...
>
> > + bus-width = <4>;
> > + no-1-8-v;
>
> ... hence no 1.8V I/O.
>
> However, VIO of WL1837 is provided by W1.8V of regulator U55,
> which is 1.8V?
>
> > + non-removable;
> > + cap-power-off-card;
> > + keep-power-in-suspend;
> > + max-frequency = <26000000>;
> > + status = "okay";
> > +
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + wlcore: wlcore@2 {
> > + compatible = "ti,wl1837";
> > + reg = <2>;
> > + interrupt-parent = <&gpio1>;
> > + interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
>
> I'm also a bit puzzled by the interrupt type.
> On Cat 874, it's IRQ_TYPE_LEVEL_HIGH, cfr.
> https://lore.kernel.org/linux-renesas-soc/1557997166-63351-2-git-send-email-biju.das@bp.renesas.com/
>
> On Kingfisher, the IRQ signal is inverted by U104, so I'd expect
> IRQ_TYPE_LEVEL_LOW instead of IRQ_TYPE_EDGE_FALLING?
>
> Apart from the above two comments:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
next prev parent reply other threads:[~2019-05-31 9:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 12:41 [PATCH] arm64: dts: ulcb-kf: Add support for TI WL1837 Spyridon Papageorgiou
2019-04-25 11:12 ` Eugeniu Rosca
2019-04-26 9:50 ` Simon Horman
2019-04-29 8:17 ` Simon Horman
2019-04-29 9:25 ` Eugeniu Rosca
2019-05-28 9:19 ` Geert Uytterhoeven
2019-05-31 9:37 ` Simon Horman [this message]
2019-05-31 13:49 ` Eugeniu Rosca
2019-06-03 11:01 ` Simon Horman
2019-05-31 15:25 ` Eugeniu Rosca
2019-06-03 7:26 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531093702.4pdbamghomqdhhuq@verge.net.au \
--to=horms@verge.net.au \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=erosca@de.adit-jv.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=spapageorgiou@de.adit-jv.com \
--cc=tfranzen@de.adit-jv.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).