From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B04A5C04AB6 for ; Fri, 31 May 2019 14:54:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FAA426B11 for ; Fri, 31 May 2019 14:54:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726762AbfEaOyi (ORCPT ); Fri, 31 May 2019 10:54:38 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:49322 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726531AbfEaOyi (ORCPT ); Fri, 31 May 2019 10:54:38 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hWivQ-0007Jr-Fx; Fri, 31 May 2019 22:54:32 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hWivM-0007Cx-9H; Fri, 31 May 2019 22:54:28 +0800 Date: Fri, 31 May 2019 22:54:28 +0800 From: Herbert Xu To: Eric Dumazet Cc: Young Xiao <92siuyang@gmail.com>, davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Steffen Klassert Subject: Re: [PATCH] ipv6: Prevent overrun when parsing v6 header options Message-ID: <20190531145428.ngwrgbnk2a7us5cy@gondor.apana.org.au> References: <1559230098-1543-1-git-send-email-92siuyang@gmail.com> <20190531062911.c6jusfbzgozqk2cu@gondor.apana.org.au> <727c4b18-0d7b-b3c6-e0bb-41b3fe5902d3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <727c4b18-0d7b-b3c6-e0bb-41b3fe5902d3@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 31, 2019 at 07:50:06AM -0700, Eric Dumazet wrote: > > What do you mean by should ? > > Are they currently already linearized before the function is called, > or is it missing and a bug needs to be fixed ? AFAICS this is the code-path for locally generated outbound packets. Under what circumstances can the IPv6 header be not in the head? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt