From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7822C04AB6 for ; Fri, 31 May 2019 15:47:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 949F826A8F for ; Fri, 31 May 2019 15:47:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726809AbfEaPrE convert rfc822-to-8bit (ORCPT ); Fri, 31 May 2019 11:47:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46594 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726518AbfEaPrE (ORCPT ); Fri, 31 May 2019 11:47:04 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 39EB3B2DE9; Fri, 31 May 2019 15:46:52 +0000 (UTC) Received: from carbon (ovpn-200-32.brq.redhat.com [10.40.200.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 51B3460BF7; Fri, 31 May 2019 15:46:45 +0000 (UTC) Date: Fri, 31 May 2019 17:46:43 +0200 From: Jesper Dangaard Brouer To: Ivan Khoronzhuk Cc: grygorii.strashko@ti.com, hawk@kernel.org, davem@davemloft.net, ast@kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, xdp-newbies@vger.kernel.org, ilias.apalodimas@linaro.org, netdev@vger.kernel.org, daniel@iogearbox.net, jakub.kicinski@netronome.com, john.fastabend@gmail.com, brouer@redhat.com Subject: Re: [PATCH v2 net-next 7/7] net: ethernet: ti: cpsw: add XDP support Message-ID: <20190531174643.4be8b27f@carbon> In-Reply-To: <20190530182039.4945-8-ivan.khoronzhuk@linaro.org> References: <20190530182039.4945-1-ivan.khoronzhuk@linaro.org> <20190530182039.4945-8-ivan.khoronzhuk@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 31 May 2019 15:47:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ivan, >From below code snippets, it looks like you only allocated 1 page_pool and sharing it with several RX-queues, as I don't have the full context and don't know this driver, I might be wrong? To be clear, a page_pool object is needed per RX-queue, as it is accessing a small RX page cache (which protected by NAPI/softirq). On Thu, 30 May 2019 21:20:39 +0300 Ivan Khoronzhuk wrote: > @@ -1404,6 +1711,14 @@ static int cpsw_ndo_open(struct net_device *ndev) > enable_irq(cpsw->irqs_table[0]); > } > > + pool_size = cpdma_get_num_rx_descs(cpsw->dma); > + cpsw->page_pool = cpsw_create_page_pool(cpsw, pool_size); > + if (IS_ERR(cpsw->page_pool)) { > + ret = PTR_ERR(cpsw->page_pool); > + cpsw->page_pool = NULL; > + goto err_cleanup; > + } On Thu, 30 May 2019 21:20:39 +0300 Ivan Khoronzhuk wrote: > @@ -675,10 +742,33 @@ int cpsw_set_ringparam(struct net_device *ndev, > if (cpsw->usage_count) > cpdma_chan_split_pool(cpsw->dma); > > + for (i = 0; i < cpsw->data.slaves; i++) { > + struct net_device *ndev = cpsw->slaves[i].ndev; > + > + if (!(ndev && netif_running(ndev))) > + continue; > + > + cpsw_xdp_unreg_rxqs(netdev_priv(ndev)); > + } > + > + page_pool_destroy(cpsw->page_pool); > + cpsw->page_pool = pool; > + On Thu, 30 May 2019 21:20:39 +0300 Ivan Khoronzhuk wrote: > +void cpsw_xdp_unreg_rxqs(struct cpsw_priv *priv) > +{ > + struct cpsw_common *cpsw = priv->cpsw; > + int i; > + > + for (i = 0; i < cpsw->rx_ch_num; i++) > + xdp_rxq_info_unreg(&priv->xdp_rxq[i]); > +} On Thu, 30 May 2019 21:20:39 +0300 Ivan Khoronzhuk wrote: > +int cpsw_xdp_reg_rxq(struct cpsw_priv *priv, int ch) > +{ > + struct xdp_rxq_info *xdp_rxq = &priv->xdp_rxq[ch]; > + struct cpsw_common *cpsw = priv->cpsw; > + int ret; > + > + ret = xdp_rxq_info_reg(xdp_rxq, priv->ndev, ch); > + if (ret) > + goto err_cleanup; > + > + ret = xdp_rxq_info_reg_mem_model(xdp_rxq, MEM_TYPE_PAGE_POOL, > + cpsw->page_pool); > + if (ret) > + goto err_cleanup; > + > + return 0; -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer