From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B68DC04AB6 for ; Fri, 31 May 2019 22:14:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E2C926FAC for ; Fri, 31 May 2019 22:14:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=brauner.io header.i=@brauner.io header.b="BAC3ltmN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726683AbfEaWOA (ORCPT ); Fri, 31 May 2019 18:14:00 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43344 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726450AbfEaWOA (ORCPT ); Fri, 31 May 2019 18:14:00 -0400 Received: by mail-wr1-f68.google.com with SMTP id m6so1735489wrj.10 for ; Fri, 31 May 2019 15:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brauner.io; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=e0zehylnRNwEoLMrCtDr0FIIIv+bm7246N0/VnWTSdI=; b=BAC3ltmN+JNBuMnr+fmkqoJ/R2Jl5ZglI9F+hoi3aeqvqtSHvB7KjA9durJerJCZlL MbdlR5Ed+iyDoBNWR+pPGjhyb1smmWtfOWf2XXKElsdhddUjuTys9W6XUQdRrhBbFGjF mGaH1m6kD7e1H3TOp+L36cVvw2k3E5sR3x7XZuw40NQOYOo6OJLn7ZluWzrAIebz0o6Y gkRwYNYL2BjdADyxBLHOw7HPuyGtEeOasqUgH/wGNYi17Q6PNJUqpytlGTWAJHgRmBLh NfxaABdmTQ7txQpL3XyymcvLMOEUt+nvKjIzNK9mXONEoUOTpXefg4E4OUQ1PyvBZM/3 N6WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=e0zehylnRNwEoLMrCtDr0FIIIv+bm7246N0/VnWTSdI=; b=F++01KWKbgkLSjTlxXgjj6vVkJQWyPfYsaM8Wko6QzWpjV9AtnLWo+LmN/LBk2V7yD DwnHUcVx7LM0em2Gy/aNMtGDQulC0hoxNtctsSWbBNsaI3RbEEDQX7oBK2ww+vs0/EG7 gqB92DOTxu5O0nCd/bWfD2VrXhYZoT15QhF8fUzV+maTV6QUhzCbv7B2a2qHjk/MdK5N wTPcCyO56+k/8zUcGPUAbadzOdazYfzFE2gUjjV7w6H+A0iAwYLPMfmQB45lmf5WfmBH 5u37U3Qf+nsVCltNxrn5eEh3iDAdc6RH1Jn0T8Vr3Le2TWy53H3RRUk59au0NASP4Zih Beyw== X-Gm-Message-State: APjAAAWGqoJ6WQuC0nYofpStAcsBKNx2OMI5xBxMXQvSz84sD8EKjds9 l1ot8JB+gsFFZIy+6SWznZTvRg== X-Google-Smtp-Source: APXvYqw0OR/H3EuEp5fqjZFM8TZ/nEGygjIjvRDRDc9VEOCCRUu9NNHqaeGl81tYfFTPe2EALCE5+A== X-Received: by 2002:adf:e583:: with SMTP id l3mr7751345wrm.1.1559340838726; Fri, 31 May 2019 15:13:58 -0700 (PDT) Received: from brauner.io (93-32-55-82.ip32.fastwebnet.it. [93.32.55.82]) by smtp.gmail.com with ESMTPSA id k2sm7898056wrx.84.2019.05.31.15.13.57 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 31 May 2019 15:13:58 -0700 (PDT) Date: Sat, 1 Jun 2019 00:13:57 +0200 From: Christian Brauner To: Linus Torvalds Cc: Andrei Vagin , Al Viro , Linux List Kernel Mailing , Jann Horn , Florian Weimer , Oleg Nesterov , Arnd Bergmann , David Howells , Pavel Emelyanov , Andrew Morton , Adrian Reber , Linux API Subject: Re: [PATCH v1 1/2] fork: add clone3 Message-ID: <20190531221356.uekyzxhtuijgj4pg@brauner.io> References: <20190529152237.10719-1-christian@brauner.io> <20190529222414.GA6492@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 31, 2019 at 01:38:29PM -0700, Linus Torvalds wrote: > On Wed, May 29, 2019 at 3:24 PM Andrei Vagin wrote: > > > > Thank you for thinking about time namespaces. I looked at this patch > > quickly and I would suggest to move a termination signal out of flags. I > > think we can add a separate field (exit_signal) into clone_args. Does it > > make sense? For me, exit_signal in flags always looked weird... > > I agree - the child signal in flags was always just a "it fits" kind > of thing, and that was obviously true back then, but is not true now. (Traveling until Monday, so sorry for delayed responses.) Yip, I agree that this is a good idea (answered Andrei's mail just now saying the same thing). I'll send out a new version of the patch with these changes added next week. Christian