From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6383C28CC6 for ; Sun, 2 Jun 2019 10:25:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99529278C0 for ; Sun, 2 Jun 2019 10:25:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726652AbfFBKZy (ORCPT ); Sun, 2 Jun 2019 06:25:54 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:56755 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726122AbfFBKZx (ORCPT ); Sun, 2 Jun 2019 06:25:53 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id D2D138037E; Sun, 2 Jun 2019 12:25:41 +0200 (CEST) Date: Sun, 2 Jun 2019 12:25:41 +0200 From: Pavel Machek To: Tony Lindgren Cc: Johan Hovold , Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, Sebastian Reichel Subject: Re: [PATCH 1/2] phy: core: Add phy_pm_runtime_enabled Message-ID: <20190602102541.GA12625@atrey.karlin.mff.cuni.cz> References: <20181117133755.9129-1-tony@atomide.com> <20181117133755.9129-2-tony@atomide.com> <20181117153845.GU19900@localhost> <20181117154353.GM53235@atomide.com> <20190602101434.GA1126@atrey.karlin.mff.cuni.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190602101434.GA1126@atrey.karlin.mff.cuni.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > > > @@ -240,6 +241,11 @@ static inline int phy_pm_runtime_put_sync(struct phy *phy) > > > > return -ENOSYS; > > > > } > > > > > > > > +static inline bool phy_pm_runtime_enabled(struct phy *phy) > > > > +{ > > > > + return false > > > > > > Missing semicolon. > > > > Oops thanks for catching that. I guess I did not try building > > without CONFIG_GENERIC_PHY. Will fix and repost. > > Did this series get lost/forgotten somewhere? Is it still needed? Any > way I can help? Aha, it seems v2 of the series was applied, which touches different files and that's why I did not detect it. Sorry for the noise. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html