From: Greg KH <gregkh@linuxfoundation.org>
To: Jim Lin <jilin@nvidia.com>
Cc: mathias.nyman@intel.com, stern@rowland.harvard.edu,
kai.heng.feng@canonical.com, drinkcat@chromium.org,
Thinh.Nguyen@synopsys.com, nsaenzjulienne@suse.de,
jflat@chromium.org, malat@debian.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 0/2] usb: xhci: Add Clear_TT_Buffer
Date: Mon, 3 Jun 2019 14:23:03 +0200 [thread overview]
Message-ID: <20190603122303.GA16267@kroah.com> (raw)
In-Reply-To: <1559559224-9845-1-git-send-email-jilin@nvidia.com>
On Mon, Jun 03, 2019 at 06:53:42PM +0800, Jim Lin wrote:
> USB 2.0 specification chapter 11.17.5 says "as part of endpoint halt
> processing for full-/low-speed endpoints connected via a TT, the host
> software must use the Clear_TT_Buffer request to the TT to ensure
> that the buffer is not in the busy state".
>
> In our case, a full-speed speaker (ConferenceCam) is behind a high-
> speed hub (ConferenceCam Connect), sometimes once we get STALL on a
> request we may continue to get STALL with the folllowing requests,
> like Set_Interface.
>
> Solution is to invoke usb_hub_clear_tt_buffer() to send
> Clear_TT_Buffer request to the hub of the device for the following
> Set_Interface requests to the device to get ACK successfully.
>
> The Clear_TT_Buffer request sent to the hub includes the address of
> the LS/FS child device in wValue field. usb_hub_clear_tt_buffer()
> uses udev->devnum to set the address wValue. This won't work for
> devices connected to xHC.
>
> For other host controllers udev->devnum is the same as the address of
> the usb device, chosen and set by usb core. With xHC the controller
> hardware assigns the address, and won't be the same as devnum.
>
> Here we have two patches.
> One is to add devaddr in struct usb_device for
> usb_hub_clear_tt_buffer() to use.
> Another is to invoke usb_hub_clear_tt_buffer() for halt processing.
Why did you resend patch series 11?
> Signed-off-by: Jim Lin <jilin@nvidia.com>
There is nothing to sign off on a 0/X patch :)
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-03 12:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 10:53 [PATCH v11 0/2] usb: xhci: Add Clear_TT_Buffer Jim Lin
2019-06-03 10:53 ` [PATCH v11 1/2] usb: Add devaddr in struct usb_device Jim Lin
2019-06-05 9:48 ` Jim Lin
2019-06-03 10:53 ` [PATCH v11 2/2] usb: xhci: Add Clear_TT_Buffer Jim Lin
2019-06-03 12:35 ` Mathias Nyman
2019-06-03 12:23 ` Greg KH [this message]
2019-06-04 8:53 ` [PATCH v11 0/2] " Jim Lin
2019-06-04 8:59 ` Greg KH
2019-06-04 14:22 ` Alan Stern
-- strict thread matches above, loose matches on Subject: below --
2019-05-29 14:55 Jim Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603122303.GA16267@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=drinkcat@chromium.org \
--cc=jflat@chromium.org \
--cc=jilin@nvidia.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=malat@debian.org \
--cc=mathias.nyman@intel.com \
--cc=nsaenzjulienne@suse.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).