linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Nick Crews <ncrews@chromium.org>,
	bleung@chromium.org, linux-leds@vger.kernel.org,
	jacek.anaszewski@gmail.com, linux-kernel@vger.kernel.org,
	dlaurie@chromium.org, sjg@google.com, groeck@google.com,
	dtor@google.com
Subject: Re: [PATCH v6] platform/chrome: Add Wilco EC keyboard backlight LEDs support
Date: Tue, 4 Jun 2019 00:13:56 +0200	[thread overview]
Message-ID: <20190603221356.GA20392@amd> (raw)
In-Reply-To: <66bafd50-1599-db70-99da-e7f5877281c2@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

Hi!

> On 9/4/19 11:55, Pavel Machek wrote:
> >> The EC is in charge of controlling the keyboard backlight on
> >> the Wilco platform. We expose a standard LED class device at
> >> /sys/class/leds/chromeos::kbd_backlight. This driver is modeled
> > 
> > As discussed, please use platform::.
> > 
> 
> Last time I looked at this patch there were some work and discussion ongoing
> about led naming in led ML, did the discussion end? I'm not able to find if
> there is a final agreement.

Jacek is working on series to clean up naming, yes.

Under new naming system, it should be
"/sys/class/leds/color:kbd_backlight", AFAICT. That is acceptable to
me.

Best regards,

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

      reply	other threads:[~2019-06-03 22:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09  0:16 [PATCH v6] platform/chrome: Add Wilco EC keyboard backlight LEDs support Nick Crews
2019-04-09  9:55 ` Pavel Machek
2019-06-03 16:35   ` Enric Balletbo i Serra
2019-06-03 22:13     ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190603221356.GA20392@amd \
    --to=pavel@ucw.cz \
    --cc=bleung@chromium.org \
    --cc=dlaurie@chromium.org \
    --cc=dtor@google.com \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@google.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=ncrews@chromium.org \
    --cc=sjg@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).