From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E16BC28CC6 for ; Tue, 4 Jun 2019 07:41:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2750824C53 for ; Tue, 4 Jun 2019 07:41:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726930AbfFDHlJ (ORCPT ); Tue, 4 Jun 2019 03:41:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:56060 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726637AbfFDHlJ (ORCPT ); Tue, 4 Jun 2019 03:41:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BB2AEADD5; Tue, 4 Jun 2019 07:41:07 +0000 (UTC) Date: Tue, 4 Jun 2019 09:41:00 +0200 From: Oscar Salvador To: Dan Williams Cc: akpm@linux-foundation.org, David Hildenbrand , Jane Chu , Michael Ellerman , Pavel Tatashin , Benjamin Herrenschmidt , Robin Murphy , Anshuman Khandual , Logan Gunthorpe , Paul Mackerras , Toshi Kani , Jeff Moyer , Michal Hocko , Vlastimil Babka , stable@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , linux-nvdimm@lists.01.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 00/12] mm: Sub-section memory hotplug support Message-ID: <20190604074056.GA2853@linux> References: <155718596657.130019.17139634728875079809.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <155718596657.130019.17139634728875079809.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 06, 2019 at 04:39:26PM -0700, Dan Williams wrote: > Changes since v7 [1]: > > - Make subsection helpers pfn based rather than physical-address based > (Oscar and Pavel) > > - Make subsection bitmap definition scalable for different section and > sub-section sizes across architectures. As a result: > > unsigned long map_active > > ...is converted to: > > DECLARE_BITMAP(subsection_map, SUBSECTIONS_PER_SECTION) > > ...and the helpers are renamed with a 'subsection' prefix. (Pavel) > > - New in this version is a touch of arch/powerpc/include/asm/sparsemem.h > in "[PATCH v8 01/12] mm/sparsemem: Introduce struct mem_section_usage" > to define ARCH_SUBSECTION_SHIFT. > > - Drop "mm/sparsemem: Introduce common definitions for the size and mask > of a section" in favor of Robin's "mm/memremap: Rename and consolidate > SECTION_SIZE" (Pavel) > > - Collect some more Reviewed-by tags. Patches that still lack review > tags: 1, 3, 9 - 12 Hi Dan, are you planning to send V10 anytime soon? After you addressed comments from Patch#9, the general implementation looks fine to me and nothing sticked out from the other patches. But I would rather wait to see v10 with the comments addressed before stamping my Reviewed-by. I am planning to fire my vmemmap patchset again [1], and I would like to re-base it on top of this work, otherwise we will face many unnecessary collisions. Thanks [1] https://patchwork.kernel.org/patch/10875025/ -- Oscar Salvador SUSE L3