From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D05C282CE for ; Tue, 4 Jun 2019 12:33:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68B102231F for ; Tue, 4 Jun 2019 12:33:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=megous.com header.i=@megous.com header.b="XZ/J6Yzq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727795AbfFDMd6 (ORCPT ); Tue, 4 Jun 2019 08:33:58 -0400 Received: from vps.xff.cz ([195.181.215.36]:60168 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727654AbfFDMd6 (ORCPT ); Tue, 4 Jun 2019 08:33:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1559651635; bh=BxxySmvFXnZjtb/3jRvUJ5xAJWsfsR3yPsxl6YMjSdM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XZ/J6YzqPnmG5/SSvTvNnIbG0FUOkSx2ZzQtC2SWzbRGDLTHYkE/9TjTjVyQbLjwx 47yTGEb8HeV2BYxRL9AEQDawcAw4Xg5XA3dxUN+GjP2OZnpImMdeH2zuif20Li4lz3 84MgE3lXOKt37uWn9fPy3MVThkkGtU93JB4rXP6Y= Date: Tue, 4 Jun 2019 14:33:55 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= Cc: Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , devicetree , linux-kernel , linux-sunxi , linux-arm-kernel , linux-media@vger.kernel.org Subject: Re: [linux-sunxi] Re: [PATCH v3 10/12] arm64: dts: allwinner: h6: Add IR receiver node Message-ID: <20190604123355.m47ufmhtzuzfvmp7@core.my.home> Mail-Followup-To: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , devicetree , linux-kernel , linux-sunxi , linux-arm-kernel , linux-media@vger.kernel.org References: <20190528161440.27172-1-peron.clem@gmail.com> <20190528161440.27172-11-peron.clem@gmail.com> <20190530145550.amalnxmx7kpokykv@core.my.home> <20190531124630.q2guo54kjfzr7rkn@core.my.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Clément, On Mon, Jun 03, 2019 at 09:58:23PM +0200, Clément Péron wrote: > Hi Ondrej, > > On Fri, 31 May 2019 at 14:46, Ondřej Jirman wrote: > > > > Hello Clément, > > > > On Fri, May 31, 2019 at 12:25:32AM +0200, Clément Péron wrote: > > > Hi Ondrej, > > > > > > On Thu, 30 May 2019 at 16:55, Ondřej Jirman wrote: > > > > > > > > Hello Clément, > > > > > > > > On Tue, May 28, 2019 at 06:14:38PM +0200, Clément Péron wrote: > > > > > Allwinner H6 IR is similar to A31 and can use same driver. > > > > > > > > > > Add support for it. > > > > > > > > > > Signed-off-by: Clément Péron > > > > > --- > > > > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 19 +++++++++++++++++++ > > > > > 1 file changed, 19 insertions(+) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > > > index 16c5c3d0fd81..649cbdfe452e 100644 > > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > > > @@ -647,6 +647,25 @@ > > > > > pins = "PL0", "PL1"; > > > > > function = "s_i2c"; > > > > > }; > > > > > + > > > > > + r_ir_rx_pin: r-ir-rx-pin { > > > > > + pins = "PL9"; > > > > > + function = "s_cir_rx"; > > > > > + }; > > > > > + }; > > > > > + > > > > > + r_ir: ir@7040000 { > > > > > + compatible = "allwinner,sun50i-h6-ir", > > > > > + "allwinner,sun6i-a31-ir"; > > > > > + reg = <0x07040000 0x400>; > > > > > + interrupts = ; > > > > > + clocks = <&r_ccu CLK_R_APB1_IR>, > > > > > + <&r_ccu CLK_IR>; > > > > > + clock-names = "apb", "ir"; > > > > > + resets = <&r_ccu RST_R_APB1_IR>; > > > > > + pinctrl-names = "default"; > > > > > + pinctrl-0 = <&r_ir_rx_pin>; > > > > > + status = "disabled"; > > > > > }; > > > > > > > > Please make a comment here, that this is known broken on some boards and may > > > > result IRQ flood if enabled. Otherwise noone will know. > > > > > > I'm planning to send a v4 next week with the IRQ_NONE return as Maxime > > > suggested it. > > > https://github.com/clementperon/linux/tree/h6_ir_v4 > > > > > > But maybe we could also use the bit 5 of the IRQ status. > > > > Thanks, that's nice, but that will not make the HW work. That will just disable > > it. The comment is still necessary. > I have pushed a new version on my github. > https://github.com/clementperon/linux/commits/h6_ir_v4 > > I will submit it, if you are ok with it. the changes make it worse. Console is flooded with "Temporarily disable IRQ" and other symptoms are the same as I described before. Interrupts are not disabled in a any reasonable time. (I've waited for more > 5mins already.) You probably need to disable interrupts right away, not wait for 100k failures. thank you and regards, o. > Thanks, > Clément > > > > > thank you, > > o. > > > > > Regards, Clement > > > > > > > > > > > thanks, > > > > o. > > > > > > > > > r_i2c: i2c@7081400 { > > > > > -- > > > > > 2.20.1 > > > > > > > > > > > > > > > _______________________________________________ > > > > > linux-arm-kernel mailing list > > > > > linux-arm-kernel@lists.infradead.org > > > > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > > > > -- > > > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > > > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > > > To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/CAJiuCce7nHSktVsDKcR8GLRpD3WrN5yP3Nb_Hbu_Q9NjUQbSMw%40mail.gmail.com. > > > For more options, visit https://groups.google.com/d/optout. > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel