linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vaneet Narang <v.narang@samsung.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Maninder Singh <maninder1.s@samsung.com>
Cc: "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"keescook@chromium.org" <keescook@chromium.org>,
	"gustavo@embeddedor.com" <gustavo@embeddedor.com>,
	"joe@perches.com" <joe@perches.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	AMIT SAHRAWAT <a.sahrawat@samsung.com>,
	PANKAJ MISHRA <pankaj.m@samsung.com>,
	Vaneet Narang <v.narang@samsung.com>
Subject: RE:(2) [PATCH 1/4] zstd: pass pointer rathen than structure to functions
Date: Tue, 04 Jun 2019 18:49:35 +0530	[thread overview]
Message-ID: <20190604131935epcms5p1c4a375fca57e4df5d233fd2769a3c2be@epcms5p1> (raw)
In-Reply-To: <20190603144132.7611b8fe3cf6928d8391a24a@linux-foundation.org>

Hi Andrew,
 
>But struct ZSTD_CCtx_s.params is still a copied structure.  Could we
>make it `const ZSTD_parameters *params'?  Probably not, due to lifetime
>issues?

ZSTD maintains its own ctxt. Yes we can avoid storing pointers of other modules
because of lifetime issues. We should keep ZSTD_CCtx_s.params as structure instead of pointer.


Thanks & Regards,
Vaneet Narang 

 
 

  parent reply	other threads:[~2019-06-04 13:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190603090227epcas5p348327061a3facbb9dfcf662bf2bc196e@epcas5p3.samsung.com>
2019-06-03  9:02 ` [PATCH 0/4] zstd: reduce stack usage Maninder Singh
     [not found]   ` <CGME20190603090232epcas5p1630d0584e8a1aa9495edc819605664fc@epcas5p1.samsung.com>
2019-06-03  9:02     ` [PATCH 1/4] zstd: pass pointer rathen than structure to functions Maninder Singh
2019-06-03 21:41       ` Andrew Morton
2019-06-04 22:43       ` Andrew Morton
2019-06-05 11:57         ` David Sterba
2019-06-05 12:32           ` David Sterba
2019-06-05 21:32             ` Andrew Morton
     [not found]       ` <CGME20190603090232epcas5p1630d0584e8a1aa9495edc819605664fc@epcms5p1>
2019-06-04 13:19         ` Vaneet Narang [this message]
2019-06-06 14:10         ` Vaneet Narang
2019-06-06 20:14           ` (2) " Nick Terrell
     [not found]   ` <CGME20190603090236epcas5p1bf0733024f7fb52f8129157b11c8f882@epcas5p1.samsung.com>
2019-06-03  9:02     ` [PATCH 2/4] zstd: use U16 data type for rankPos Maninder Singh
     [not found]   ` <CGME20190603090240epcas5p17d0881686df3fa3042d0b2d659e925b3@epcas5p1.samsung.com>
2019-06-03  9:02     ` [PATCH 3/4] zstd: move params structure to global variable to reduce stack usage Maninder Singh
2019-06-03 21:47       ` Andrew Morton
     [not found]   ` <CGME20190603090245epcas5p4a6cdfdb7ef72bfd36472f43bb4e1e0f1@epcas5p4.samsung.com>
2019-06-03  9:02     ` [PATCH 4/4] zstd: change structure variable from int to char Maninder Singh
2019-06-03 21:49   ` [PATCH 0/4] zstd: reduce stack usage Andrew Morton
     [not found]   ` <CGME20190603090227epcas5p348327061a3facbb9dfcf662bf2bc196e@epcms5p3>
2019-06-04 12:06     ` Vaneet Narang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190604131935epcms5p1c4a375fca57e4df5d233fd2769a3c2be@epcms5p1 \
    --to=v.narang@samsung.com \
    --cc=a.sahrawat@samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=gustavo@embeddedor.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maninder1.s@samsung.com \
    --cc=pankaj.m@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).