From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9127C46470 for ; Thu, 6 Jun 2019 06:37:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBAB320868 for ; Thu, 6 Jun 2019 06:37:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726454AbfFFGhd (ORCPT ); Thu, 6 Jun 2019 02:37:33 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:37922 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbfFFGhd (ORCPT ); Thu, 6 Jun 2019 02:37:33 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hYm1g-0006bn-NT; Thu, 06 Jun 2019 14:37:28 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hYm1c-0003k2-At; Thu, 06 Jun 2019 14:37:24 +0800 Date: Thu, 6 Jun 2019 14:37:24 +0800 From: Herbert Xu To: Ard Biesheuvel Cc: Iuliana Prodan , Eric Biggers , "David S. Miller" , Horia Geanta , Sascha Hauer , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Linux Kernel Mailing List , dl-linux-imx Subject: Re: [PATCH] crypto: gcm - fix cacheline sharing Message-ID: <20190606063724.n77z7gaf32tmyxng@gondor.apana.org.au> References: <20190529202728.GA35103@gmail.com> <20190530133427.qrwjzctac2x6nsby@gondor.apana.org.au> <20190530142734.qlhgzeal22zxfhk5@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 30, 2019 at 04:31:09PM +0200, Ard Biesheuvel wrote: > > This might work: > > diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c > index c0ece44f303b..3d313d2a279a 100644 > --- a/drivers/crypto/caam/caamalg.c > +++ b/drivers/crypto/caam/caamalg.c > @@ -1661,7 +1661,8 @@ static int aead_decrypt(struct aead_request *req) > * allocate and map the skcipher extended descriptor for skcipher > */ > static struct skcipher_edesc *skcipher_edesc_alloc(struct > skcipher_request *req, > - int desc_bytes) > + int desc_bytes, > + u8 const *input_iv) > { > struct crypto_skcipher *skcipher = crypto_skcipher_reqtfm(req); > struct caam_ctx *ctx = crypto_skcipher_ctx(skcipher); > @@ -1745,7 +1746,7 @@ static struct skcipher_edesc > *skcipher_edesc_alloc(struct skcipher_request *req, > /* Make sure IV is located in a DMAable area */ > if (ivsize) { > iv = (u8 *)edesc->hw_desc + desc_bytes + sec4_sg_bytes; > - memcpy(iv, req->iv, ivsize); > + memcpy(iv, input_iv, ivsize); > > iv_dma = dma_map_single(jrdev, iv, ivsize, DMA_TO_DEVICE); > if (dma_mapping_error(jrdev, iv_dma)) { Hi Ard: I presume you will be submitting this patch at some point? When you do please base it on top of your other one which I'm about to merge. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt