From: Mark Rutland <mark.rutland@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Will Deacon <will.deacon@arm.com>,
James Morse <james.morse@arm.com>,
Andrey Konovalov <andreyknvl@google.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V2 4/4] arm64/mm: Drop local variable vm_fault_t from __do_page_fault()
Date: Thu, 6 Jun 2019 12:31:17 +0100 [thread overview]
Message-ID: <20190606113117.GC37821@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20190606112739.GB56860@arrakis.emea.arm.com>
On Thu, Jun 06, 2019 at 12:27:40PM +0100, Catalin Marinas wrote:
> On Thu, Jun 06, 2019 at 10:24:01AM +0530, Anshuman Khandual wrote:
> > On 06/04/2019 08:26 PM, Catalin Marinas wrote:
> > > On Mon, Jun 03, 2019 at 12:11:25PM +0530, Anshuman Khandual wrote:
> > >> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> > >> index 4bb65f3..41fa905 100644
> > >> --- a/arch/arm64/mm/fault.c
> > >> +++ b/arch/arm64/mm/fault.c
> > >> @@ -397,37 +397,29 @@ static void do_bad_area(unsigned long addr, unsigned int esr, struct pt_regs *re
> > >> static vm_fault_t __do_page_fault(struct mm_struct *mm, unsigned long addr,
> > >> unsigned int mm_flags, unsigned long vm_flags)
> > >> {
> > >> - struct vm_area_struct *vma;
> > >> - vm_fault_t fault;
> > >> + struct vm_area_struct *vma = find_vma(mm, addr);
> > >>
> > >> - vma = find_vma(mm, addr);
> > >> - fault = VM_FAULT_BADMAP;
> > >> if (unlikely(!vma))
> > >> - goto out;
> > >> - if (unlikely(vma->vm_start > addr))
> > >> - goto check_stack;
> > >> + return VM_FAULT_BADMAP;
> > >>
> > >> /*
> > >> * Ok, we have a good vm_area for this memory access, so we can handle
> > >> * it.
> > >> */
> > >> -good_area:
> > >> + if (unlikely(vma->vm_start > addr)) {
> > >> + if (!(vma->vm_flags & VM_GROWSDOWN))
> > >> + return VM_FAULT_BADMAP;
> > >> + if (expand_stack(vma, addr))
> > >> + return VM_FAULT_BADMAP;
> > >> + }
> > >
> > > You could have a single return here:
> > >
> > > if (unlikely(vma->vm_start > addr) &&
> > > (!(vma->vm_flags & VM_GROWSDOWN) || expand_stack(vma, addr)))
> > > return VM_FAULT_BADMAP;
> > >
> > > Not sure it's any clearer though.
> >
> > TBH the proposed one seems clearer as it separates effect (vma->vm_start > addr)
> > from required permission check (vma->vm_flags & VM_GROWSDOWN) and required action
> > (expand_stack(vma, addr)). But I am happy to change as you have mentioned if that
> > is preferred.
>
> Not bothered really. You can leave them as in your proposal (I was just
> seeing the VM_GROWSDOWN check tightly coupled with the expand_stack(),
> it's fine either way).
Personally, I find it clearer as separate statements, so I'd suggest
keeping it as per Anshuman's proposal.
Thanks,
Mark.
prev parent reply other threads:[~2019-06-06 11:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 6:41 [PATCH V2 0/4] arm64/mm: Clean ups for do_page_fault() Anshuman Khandual
2019-06-03 6:41 ` [PATCH V2 1/4] arm64/mm: Drop mmap_sem before calling __do_kernel_fault() Anshuman Khandual
2019-06-04 14:44 ` Catalin Marinas
2019-06-03 6:41 ` [PATCH V2 2/4] arm64/mm: Drop task_struct argument from __do_page_fault() Anshuman Khandual
2019-06-04 14:45 ` Catalin Marinas
2019-06-03 6:41 ` [PATCH V2 3/4] arm64/mm: Consolidate page fault information capture Anshuman Khandual
2019-06-04 14:42 ` Catalin Marinas
2019-06-06 9:38 ` Mark Rutland
2019-06-06 11:23 ` Catalin Marinas
2019-06-03 6:41 ` [PATCH V2 4/4] arm64/mm: Drop local variable vm_fault_t from __do_page_fault() Anshuman Khandual
2019-06-04 14:56 ` Catalin Marinas
2019-06-06 4:54 ` Anshuman Khandual
2019-06-06 11:27 ` Catalin Marinas
2019-06-06 11:31 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606113117.GC37821@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=andreyknvl@google.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=hch@infradead.org \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).