From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F45C2BCA1 for ; Fri, 7 Jun 2019 15:54:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80C5A208C3 for ; Fri, 7 Jun 2019 15:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559922895; bh=lhup+GxE6NjPA2SqoQevbexaE1RfhCEU0FEh9xcnTZ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uYxFiy2D3Nb8aEYa3RZ9ih33Ra0d5ZbVt/Sos9vOYluG4YjInl+d8QoyWKkflK7Sz 3s3bY/7+HyQi7Xlp4VAziWLFOQngJyYgZILHRWtSddMWRa30F1Z2gdgf8/Dh4J3nnz SjjEZeE+iquY42QFNHin99VoYO8enqVBK7hy/oqE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731387AbfFGPqY (ORCPT ); Fri, 7 Jun 2019 11:46:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:58560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731378AbfFGPqU (ORCPT ); Fri, 7 Jun 2019 11:46:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 51A2A2146E; Fri, 7 Jun 2019 15:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559922379; bh=lhup+GxE6NjPA2SqoQevbexaE1RfhCEU0FEh9xcnTZ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L3DuMIpBji4looPVVyBvZdZtyC510gP59lJ23tTqNZgu3M2BXtLF9VUNEkqboUNvU yBfoM56LBvw8FUzS4t6VKWeSRDnGcMW6XQPBFWXzXEYRQHbP5miU4U8VBkaeCjmk6h 0J9SJ8QNG6IjbBdrIxglqmyE1gqpoD1Ue+b3cUi8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ben Hutchings , Todd Kjos Subject: [PATCH 4.19 65/73] Revert "binder: fix handling of misaligned binder object" Date: Fri, 7 Jun 2019 17:39:52 +0200 Message-Id: <20190607153856.164180391@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190607153848.669070800@linuxfoundation.org> References: <20190607153848.669070800@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Todd Kjos This reverts commit 6bf7d3c5c0c5dad650bfc4345ed553c18b69d59e. The commit message is for a different patch. Reverting and then adding the same patch back with the correct commit message. Reported-by: Ben Hutchings Cc: stable # 4.19 Signed-off-by: Todd Kjos Signed-off-by: Greg Kroah-Hartman --- drivers/android/binder_alloc.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) --- a/drivers/android/binder_alloc.c +++ b/drivers/android/binder_alloc.c @@ -958,13 +958,14 @@ enum lru_status binder_alloc_free_page(s index = page - alloc->pages; page_addr = (uintptr_t)alloc->buffer + index * PAGE_SIZE; - - mm = alloc->vma_vm_mm; - if (!mmget_not_zero(mm)) - goto err_mmget; - if (!down_write_trylock(&mm->mmap_sem)) - goto err_down_write_mmap_sem_failed; vma = binder_alloc_get_vma(alloc); + if (vma) { + if (!mmget_not_zero(alloc->vma_vm_mm)) + goto err_mmget; + mm = alloc->vma_vm_mm; + if (!down_write_trylock(&mm->mmap_sem)) + goto err_down_write_mmap_sem_failed; + } list_lru_isolate(lru, item); spin_unlock(lock); @@ -977,9 +978,10 @@ enum lru_status binder_alloc_free_page(s PAGE_SIZE); trace_binder_unmap_user_end(alloc, index); + + up_write(&mm->mmap_sem); + mmput(mm); } - up_write(&mm->mmap_sem); - mmput(mm); trace_binder_unmap_kernel_start(alloc, index);