From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35FC0C28EBD for ; Sun, 9 Jun 2019 17:14:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F34A120652 for ; Sun, 9 Jun 2019 17:14:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560100475; bh=gVTEveb/aumh0iU0IEwtM0Zuf7f6w6/4SFOhMCJm8lk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oo2rpa2AdPmaeOUjve3cnBcl4+yQXmc010EtwrNS864dGfuesISNa1ZD0zeS0ZoXV 4XT55Be9g6S2NKotXNdD8jReziju03zQ+4fKXHtx9rsHpsHpuEPyzdxrbmRZTpoZ/v WRJd0zN3mXwysG48Th7QockxprEwg1YQ9MEcZA4E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733001AbfFIQ4d (ORCPT ); Sun, 9 Jun 2019 12:56:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:59028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732987AbfFIQ43 (ORCPT ); Sun, 9 Jun 2019 12:56:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2978C206DF; Sun, 9 Jun 2019 16:56:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560099388; bh=gVTEveb/aumh0iU0IEwtM0Zuf7f6w6/4SFOhMCJm8lk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gN1JOwo4WBSvDVfRspXbtA+8HEA3/t/bdZlPOA7GvwjAJTQJk62nFO9GCFLEbPxmx cvCAXLuHO75O0jrqI+BfPazEjZoXJhKlKbPIUQoEixNqjGJqwt6Q5T1yWIjzNcQpPx Unr7lm/g/fnX9SyzgaE3jC6RqneGcec2lQThkeig= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenwen Wang , Takashi Iwai Subject: [PATCH 4.4 007/241] ALSA: usb-audio: Fix a memory leak bug Date: Sun, 9 Jun 2019 18:39:09 +0200 Message-Id: <20190609164147.999654229@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190609164147.729157653@linuxfoundation.org> References: <20190609164147.729157653@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wenwen Wang commit cb5173594d50c72b7bfa14113dfc5084b4d2f726 upstream. In parse_audio_selector_unit(), the string array 'namelist' is allocated through kmalloc_array(), and each string pointer in this array, i.e., 'namelist[]', is allocated through kmalloc() in the following for loop. Then, a control instance 'kctl' is created by invoking snd_ctl_new1(). If an error occurs during the creation process, the string array 'namelist', including all string pointers in the array 'namelist[]', should be freed, before the error code ENOMEM is returned. However, the current code does not free 'namelist[]', resulting in memory leaks. To fix the above issue, free all string pointers 'namelist[]' in a loop. Signed-off-by: Wenwen Wang Cc: Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/mixer.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -2112,6 +2112,8 @@ static int parse_audio_selector_unit(str kctl = snd_ctl_new1(&mixer_selectunit_ctl, cval); if (! kctl) { usb_audio_err(state->chip, "cannot malloc kcontrol\n"); + for (i = 0; i < desc->bNrInPins; i++) + kfree(namelist[i]); kfree(namelist); kfree(cval); return -ENOMEM;