From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A89FC28EBD for ; Sun, 9 Jun 2019 17:01:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44636206C3 for ; Sun, 9 Jun 2019 17:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560099661; bh=33ENuQdkgb5WlAbIhczPk0TBBrswmN9/HAGagNFzDC8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=aydDyJY/jNHeifIiPvXZpowKiI3QYZxfSLfFq2wvx1UE4YXdof4kpta36dwdr7Izf Ce9e+mvo5CRfkjSwkuSqg+boeGxlMem00dRb598tMhs7lbLFw4P82grqJyVHb9sFfi fzDuzdVcO0nxSBMRce6PyR+B5aYIVMUiUfItYmig= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733241AbfFIRBA (ORCPT ); Sun, 9 Jun 2019 13:01:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:37816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387951AbfFIRA5 (ORCPT ); Sun, 9 Jun 2019 13:00:57 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B79720833; Sun, 9 Jun 2019 17:00:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560099656; bh=33ENuQdkgb5WlAbIhczPk0TBBrswmN9/HAGagNFzDC8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b03jMtAJ67K3M3OfeJccbny3bHgmr8zj3K2xvjunUJZs0rFbO0uP6ebqxOmGw7LZx gqK/i0Ytrh9/92CEdLgXluy+E14Dz6c2n0G4ZbU6oGL5s5B7VA8XTlDc5ntzFtWP1n EXy5xBEVcWsga5ksGeRuv0SZuKJhNNKj17xSj8e8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Philipp Zabel , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.4 118/241] media: coda: clear error return value before picture run Date: Sun, 9 Jun 2019 18:41:00 +0200 Message-Id: <20190609164151.206971968@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190609164147.729157653@linuxfoundation.org> References: <20190609164147.729157653@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit bbeefa7357a648afe70e7183914c87c3878d528d ] The error return value is not written by some firmware codecs, such as MPEG-2 decode on CodaHx4. Clear the error return value before starting the picture run to avoid misinterpreting unrelated values returned by sequence initialization as error return value. Signed-off-by: Philipp Zabel Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/coda/coda-bit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c index d76511c1c1e3f..a4639813cf35d 100644 --- a/drivers/media/platform/coda/coda-bit.c +++ b/drivers/media/platform/coda/coda-bit.c @@ -1829,6 +1829,9 @@ static int coda_prepare_decode(struct coda_ctx *ctx) /* Clear decode success flag */ coda_write(dev, 0, CODA_RET_DEC_PIC_SUCCESS); + /* Clear error return value */ + coda_write(dev, 0, CODA_RET_DEC_PIC_ERR_MB); + trace_coda_dec_pic_run(ctx, meta); coda_command_async(ctx, CODA_COMMAND_PIC_RUN); -- 2.20.1