From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F059C28EBD for ; Sun, 9 Jun 2019 17:06:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35B46206C3 for ; Sun, 9 Jun 2019 17:06:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560099985; bh=dbiKq53ZEdnYqOxVXfRDsv9rp54xWHJH215bvi/pXPY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JuUDcuhrC4g3BsIcmRysBxgTy2BQ5BOCdh7PcAISWJx+CkvrfMJnjtNntzTHJTq1l 7/Jh/UMJ62zIla5bqgRpwMtLYeNPILfYLT7ywC3JwBCEMrOqGjQZj7yKwaPnGxPN1t S1CmN6eDun87N+FPYrCG5Sybma2lz7U9bO38gZvw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389008AbfFIRGY (ORCPT ); Sun, 9 Jun 2019 13:06:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:46040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388588AbfFIRGV (ORCPT ); Sun, 9 Jun 2019 13:06:21 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5029D204EC; Sun, 9 Jun 2019 17:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560099980; bh=dbiKq53ZEdnYqOxVXfRDsv9rp54xWHJH215bvi/pXPY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2N98+dLwzRCBDXIJWKoacstGDJTFIl/aHx5vXYvL4OE3+50BEVh1eXdXrgqXDyK1g YhdGaxWgL7z66UsZK3KM1DEIiKP5sMyWwT2YezbcBgqdM/NqWneCZ8GNdwYm7hm8x0 M1ctXJz0ImVnKev/eW/ki2zCWOjvwMboXZDrhl7Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nadav Amit , Laurent Pinchart , Mauro Carvalho Chehab , Doug Anderson , Ben Hutchings Subject: [PATCH 4.4 228/241] media: uvcvideo: Fix uvc_alloc_entity() allocation alignment Date: Sun, 9 Jun 2019 18:42:50 +0200 Message-Id: <20190609164155.298801610@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190609164147.729157653@linuxfoundation.org> References: <20190609164147.729157653@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nadav Amit commit 89dd34caf73e28018c58cd193751e41b1f8bdc56 upstream. The use of ALIGN() in uvc_alloc_entity() is incorrect, since the size of (entity->pads) is not a power of two. As a stop-gap, until a better solution is adapted, use roundup() instead. Found by a static assertion. Compile-tested only. Fixes: 4ffc2d89f38a ("uvcvideo: Register subdevices for each entity") Signed-off-by: Nadav Amit Signed-off-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab Cc: Doug Anderson Cc: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/uvc/uvc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -868,7 +868,7 @@ static struct uvc_entity *uvc_alloc_enti unsigned int size; unsigned int i; - extra_size = ALIGN(extra_size, sizeof(*entity->pads)); + extra_size = roundup(extra_size, sizeof(*entity->pads)); num_inputs = (type & UVC_TERM_OUTPUT) ? num_pads : num_pads - 1; size = sizeof(*entity) + extra_size + sizeof(*entity->pads) * num_pads + num_inputs;