From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH v2 1/4] perf trace: Exit when build eBPF program failure
Date: Mon, 10 Jun 2019 15:38:25 +0800 [thread overview]
Message-ID: <20190610073825.GB6140@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20190606133424.GB30166@kernel.org>
On Thu, Jun 06, 2019 at 10:34:24AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jun 06, 2019 at 10:30:19AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Thu, Jun 06, 2019 at 05:48:42PM +0800, Leo Yan escreveu:
> > > +++ b/tools/perf/builtin-trace.c
> > > @@ -3664,6 +3664,14 @@ static int trace__config(const char *var, const char *value, void *arg)
> > > "event selector. use 'perf list' to list available events",
> > > parse_events_option);
> > > err = parse_events_option(&o, value, 0);
> > > +
> > > + /*
> > > + * When parse option successfully parse_events_option() will
> > > + * return 0, otherwise means the paring failure. And it
> > > + * returns 1 for eBPF program building failure; so adjust the
> > > + * err value to -1 for the failure.
> > > + */
> > > + err = err ? -1 : 0;
> >
> > I'll rewrite the comment above to make it more succint and fix things
> > like 'paring' (parsing):
> >
> > /*
> > * parse_events_option() returns !0 to indicate failure
> > * while the perf_config code that calls trace__config()
> > * expects < 0 returns to indicate error, so:
> > */
> >
> > if (err)
> > err = -1;
>
> Even shorter, please let me know if I can keep your
> Signed-off-by/authorship for this one.
Sorry I miss this email.
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index f7e4e50bddbd..1a2a605cf068 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -3703,7 +3703,12 @@ static int trace__config(const char *var, const char *value, void *arg)
> struct option o = OPT_CALLBACK('e', "event", &trace->evlist, "event",
> "event selector. use 'perf list' to list available events",
> parse_events_option);
> - err = parse_events_option(&o, value, 0);
> + /*
> + * We can't propagate parse_event_option() return, as it is 1
> + * for failure while perf_config() expects -1.
> + */
> + if (parse_events_option(&o, value, 0))
> + err = -1;
> } else if (!strcmp(var, "trace.show_timestamp")) {
> trace->show_tstamp = perf_config_bool(var, value);
> } else if (!strcmp(var, "trace.show_duration")) {
Yeah, the change looks good to me. And very appreciate your effort to
improve the patch quality.
Thanks,
Leo.
next prev parent reply other threads:[~2019-06-10 7:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 9:48 [PATCH v2 0/4] perf augmented_raw_syscalls: Support for arm64 Leo Yan
2019-06-06 9:48 ` [PATCH v2 1/4] perf trace: Exit when build eBPF program failure Leo Yan
2019-06-06 13:30 ` Arnaldo Carvalho de Melo
2019-06-06 13:34 ` Arnaldo Carvalho de Melo
2019-06-10 7:38 ` Leo Yan [this message]
2019-06-06 13:56 ` Leo Yan
2019-06-06 9:48 ` [PATCH v2 2/4] perf augmented_raw_syscalls: Remove duplicate macros Leo Yan
2019-06-06 9:48 ` [PATCH v2 3/4] perf augmented_raw_syscalls: Support arm64 raw syscalls Leo Yan
2019-06-06 13:38 ` Arnaldo Carvalho de Melo
2019-06-06 13:46 ` Arnaldo Carvalho de Melo
2019-06-06 14:05 ` Arnaldo Carvalho de Melo
2019-06-06 14:12 ` Leo Yan
2019-06-06 14:44 ` Arnaldo Carvalho de Melo
2019-06-07 9:58 ` Leo Yan
2019-06-09 13:18 ` Leo Yan
2019-06-10 18:47 ` Arnaldo Carvalho de Melo
2019-06-11 4:18 ` Leo Yan
2019-06-12 2:49 ` Arnaldo Carvalho de Melo
2019-06-13 18:15 ` Arnaldo Carvalho de Melo
2019-06-15 5:52 ` Leo Yan
2019-06-22 6:44 ` [tip:perf/core] perf trace: Fix exclusion of not available syscall names from selector list tip-bot for Arnaldo Carvalho de Melo
2019-06-17 19:53 ` [tip:perf/core] perf trace: Skip unknown syscalls when expanding strace like syscall groups tip-bot for Arnaldo Carvalho de Melo
2019-06-06 9:48 ` [PATCH v2 4/4] perf augmented_raw_syscalls: Document clang configuration Leo Yan
2019-06-06 14:08 ` Arnaldo Carvalho de Melo
2019-06-06 14:35 ` Leo Yan
2019-06-06 18:29 ` Arnaldo Carvalho de Melo
2019-06-07 14:38 ` Leo Yan
2019-06-07 18:33 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610073825.GB6140@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@redhat.com \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=suzuki.poulose@arm.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).