From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sugaya Taichi <sugaya.taichi@socionext.com>
Cc: Jiri Slaby <jslaby@suse.com>,
Takao Orito <orito.takao@socionext.com>,
Kazuhiro Kasai <kasai.kazuhiro@socionext.com>,
Shinji Kanematsu <kanematsu.shinji@socionext.com>,
Jassi Brar <jaswinder.singh@linaro.org>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: Fix an invalid comparing statement
Date: Mon, 10 Jun 2019 18:56:55 +0200 [thread overview]
Message-ID: <20190610165655.GA397@kroah.com> (raw)
In-Reply-To: <1558933288-30023-1-git-send-email-sugaya.taichi@socionext.com>
On Mon, May 27, 2019 at 02:01:27PM +0900, Sugaya Taichi wrote:
> Drop the if-statement which refers to 8th bit field of u8 variable.
> The bit field is no longer used.
>
> Fixes: ba44dc043004 ("serial: Add Milbeaut serial control")
> Reported-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com>
> ---
> drivers/tty/serial/milbeaut_usio.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/tty/serial/milbeaut_usio.c b/drivers/tty/serial/milbeaut_usio.c
> index 949ab7e..d7207ab 100644
> --- a/drivers/tty/serial/milbeaut_usio.c
> +++ b/drivers/tty/serial/milbeaut_usio.c
> @@ -56,7 +56,6 @@
> #define MLB_USIO_SSR_FRE BIT(4)
> #define MLB_USIO_SSR_PE BIT(5)
> #define MLB_USIO_SSR_REC BIT(7)
> -#define MLB_USIO_SSR_BRK BIT(8)
> #define MLB_USIO_FCR_FE1 BIT(0)
> #define MLB_USIO_FCR_FE2 BIT(1)
> #define MLB_USIO_FCR_FCL1 BIT(2)
> @@ -180,18 +179,14 @@ static void mlb_usio_rx_chars(struct uart_port *port)
> if (status & MLB_USIO_SSR_ORE)
> port->icount.overrun++;
> status &= port->read_status_mask;
> - if (status & MLB_USIO_SSR_BRK) {
> - flag = TTY_BREAK;
> + if (status & MLB_USIO_SSR_PE) {
> + flag = TTY_PARITY;
> ch = 0;
> } else
> - if (status & MLB_USIO_SSR_PE) {
> - flag = TTY_PARITY;
> + if (status & MLB_USIO_SSR_FRE) {
> + flag = TTY_FRAME;
> ch = 0;
> - } else
> - if (status & MLB_USIO_SSR_FRE) {
> - flag = TTY_FRAME;
> - ch = 0;
> - }
> + }
> if (flag)
> uart_insert_char(port, status, MLB_USIO_SSR_ORE,
> ch, flag);
While the code never actually supported Break, you are explicitly
removing that logic now. So shouldn't you instead _fix_ break handling?
The code before and after your change does not work any differently, so
this patch isn't really needed at this point.
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-10 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 5:01 [PATCH] serial: Fix an invalid comparing statement Sugaya Taichi
2019-06-10 11:31 ` Sugaya, Taichi
2019-06-10 16:56 ` Greg Kroah-Hartman [this message]
2019-06-12 9:18 ` Sugaya, Taichi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610165655.GA397@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jaswinder.singh@linaro.org \
--cc=jslaby@suse.com \
--cc=kanematsu.shinji@socionext.com \
--cc=kasai.kazuhiro@socionext.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=orito.takao@socionext.com \
--cc=sugaya.taichi@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).