From: Oleksij Rempel <o.rempel@pengutronix.de>
To: daniel.baluta@nxp.com
Cc: jassisinghbrar@gmail.com, aisheng.dong@nxp.com,
shawnguo@kernel.org, s.hauer@pengutronix.de,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 1/2] mailbox: imx: Clear GIEn bit at shutdown
Date: Tue, 11 Jun 2019 06:33:15 +0200 [thread overview]
Message-ID: <20190611043315.mr72owvjrxkegdww@pengutronix.de> (raw)
In-Reply-To: <20190610141609.17559-2-daniel.baluta@nxp.com>
On Mon, Jun 10, 2019 at 10:16:08PM +0800, daniel.baluta@nxp.com wrote:
> From: Daniel Baluta <daniel.baluta@nxp.com>
>
> GIEn is enabled at startup for RX doorbell mailboxes so
> we need to clear the bit at shutdown in order to avoid
> leaving the interrupt line enabled.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Please send bug fixes separately from RFC patches.
You can add my
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/mailbox/imx-mailbox.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index 25be8bb5e371..9f74dee1a58c 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -217,8 +217,8 @@ static void imx_mu_shutdown(struct mbox_chan *chan)
> if (cp->type == IMX_MU_TYPE_TXDB)
> tasklet_kill(&cp->txdb_tasklet);
>
> - imx_mu_xcr_rmw(priv, 0,
> - IMX_MU_xCR_TIEn(cp->idx) | IMX_MU_xCR_RIEn(cp->idx));
> + imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_TIEn(cp->idx) |
> + IMX_MU_xCR_RIEn(cp->idx) | IMX_MU_xCR_GIEn(cp->idx));
>
> free_irq(priv->irq, chan);
> }
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2019-06-11 4:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 14:16 [RFC PATCH 0/2] Introduce Tx doorbell with ACK daniel.baluta
2019-06-10 14:16 ` [RFC PATCH 1/2] mailbox: imx: Clear GIEn bit at shutdown daniel.baluta
2019-06-11 4:33 ` Oleksij Rempel [this message]
2019-06-10 14:16 ` [RFC PATCH 2/2] imx: mailbox: Introduce TX doorbell with ACK daniel.baluta
2019-06-11 5:55 ` Oleksij Rempel
2019-06-11 7:52 ` Daniel Baluta
2019-06-11 8:40 ` Oleksij Rempel
2019-06-12 6:51 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611043315.mr72owvjrxkegdww@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=aisheng.dong@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).