From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mei: no need to check return value of debugfs_create functions
Date: Tue, 11 Jun 2019 20:34:29 +0200 [thread overview]
Message-ID: <20190611183429.GA32159@kroah.com> (raw)
In-Reply-To: <20190611183357.GA32008@kroah.com>
On Tue, Jun 11, 2019 at 08:33:57PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Tomas Winkler <tomas.winkler@intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/misc/genwqe/card_base.c | 5 -
> drivers/misc/genwqe/card_base.h | 2 +-
> drivers/misc/genwqe/card_debugfs.c | 165 +++++----------------------
> drivers/misc/genwqe/card_dev.c | 6 +-
> drivers/misc/mei/debugfs.c | 47 ++------
> drivers/misc/mei/main.c | 8 +-
> drivers/misc/mei/mei_dev.h | 7 +-
> drivers/misc/mic/card/mic_debugfs.c | 18 +--
> drivers/misc/mic/cosm/cosm_debugfs.c | 4 -
> drivers/misc/mic/host/mic_debugfs.c | 4 -
> drivers/misc/mic/scif/scif_debugfs.c | 5 -
> drivers/misc/mic/vop/vop_debugfs.c | 4 -
> drivers/misc/ti-st/st_kim.c | 4 -
> drivers/misc/vmw_balloon.c | 19 +--
> 14 files changed, 51 insertions(+), 247 deletions(-)
Ugh, nope, wrong patch, need to break this one up, sorry...
greg k-h
next prev parent reply other threads:[~2019-06-11 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 18:33 [PATCH] mei: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-11 18:34 ` Greg Kroah-Hartman [this message]
2019-06-11 18:38 ` [PATCH v2] " Greg Kroah-Hartman
2019-06-19 8:25 ` Winkler, Tomas
2019-06-19 13:00 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611183429.GA32159@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).