linux-next: Fixes tag needs some work in the drivers-x86 tree

linux-next: Fixes tag needs some work in the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

Hi all,

In commit

  097d45dd45d8 ("Platform: OLPC: Fix olpc_xo175_ec_cmd() return value")

Fixes tag

  Fixes: commit 0c3d931b3ab9 ("Platform: OLPC: Add XO-1.75 EC driver")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drivers-x86 tree

[Hans de Goede]

Hi,

On 3/1/22 22:17, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   646f429ec2de ("platform/x86: amd-pmc: Set QOS during suspend on CZN w/ timer wakeup")
> 
> Fixes tag
> 
>   Fixes: 59348401ebed ("platform/x86: amd-pmc: Add special handling for timer based S0i3 wakeup"
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses

Thanks. I've fixed this and done a forced push to drivers-x86/for-next with
the fixed commit.

Regards,

Hans

linux-next: Fixes tag needs some work in the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

Hi all,

In commit

  646f429ec2de ("platform/x86: amd-pmc: Set QOS during suspend on CZN w/ timer wakeup")

Fixes tag

  Fixes: 59348401ebed ("platform/x86: amd-pmc: Add special handling for timer based S0i3 wakeup"

has these problem(s):

  - Subject has leading but no trailing parentheses

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drivers-x86 tree

[Hans de Goede]

Hi Stephen,

On 11/1/21 22:37, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   7885061a10f4 ("platform/x86: system76_acpi: Fix input device error handling")
> 
> Fixes tag
> 
>   Fixes: 0de30fc684b ("platform/x86: system76_acpi: Replace Fn+F2 function for OLED models")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
> 
> Also, please keep all the commit tags together at the end of the commit
> message.

Thank you for reporting this, I've fixed up both issues and done
a forced-push of my for-next branch.

Regards,

Hans

linux-next: Fixes tag needs some work in the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Hi all,

In commit

  7885061a10f4 ("platform/x86: system76_acpi: Fix input device error handling")

Fixes tag

  Fixes: 0de30fc684b ("platform/x86: system76_acpi: Replace Fn+F2 function for OLED models")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

Also, please keep all the commit tags together at the end of the commit
message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drivers-x86 tree

[Hans de Goede]

Hi,

On 8/11/21 12:16 AM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   5c62c3d98b87 ("platform/x86: ISST: Fix optimization with use of numa")
> 
> Fixes tag
> 
>   Fixes: aa2ddd242572 ("ISST: Use numa node id for cpu pci dev mapping")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Thanks, I've fixes this now and then a forced-push of the pdx86 for-next branch.

Question, is there some script which I can run on my own tree to catch
this (and similar issues) myself?  checkpatch does not catch this problem.

Regards,

Hans

linux-next: Fixes tag needs some work in the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

Hi all,

In commit

  5c62c3d98b87 ("platform/x86: ISST: Fix optimization with use of numa")

Fixes tag

  Fixes: aa2ddd242572 ("ISST: Use numa node id for cpu pci dev mapping")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drivers-x86 tree

[Hans de Goede]

Hi,

On 3/8/21 7:06 AM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   b5b5ff84fd93 ("platform/surface: aggregator: Make SSAM_DEFINE_SYNC_REQUEST_x define static functions")
> 
> Fixes tag
> 
>   Fixes: 510c8114fc74 ("platform/surface: Add platform profile driver")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: b78b4982d763 ("platform/surface: Add platform profile driver")

Yeah, this was caused by rebasing my branches from v5.12-rc1 as base to v5.12-rc2 as base,
I've fixed this now, thank you for the report.

Regards,

Hans

linux-next: Fixes tag needs some work in the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

Hi all,

In commit

  b5b5ff84fd93 ("platform/surface: aggregator: Make SSAM_DEFINE_SYNC_REQUEST_x define static functions")

Fixes tag

  Fixes: 510c8114fc74 ("platform/surface: Add platform profile driver")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: b78b4982d763 ("platform/surface: Add platform profile driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

Hi Hans,

On Mon, 30 Nov 2020 08:43:21 +0100 Hans de Goede <hdegoede@redhat.com> wrote:
>
> Question, how important is it to fix these ? I normally never do forced pushes
> to the for-next branch. But if this is considered important to fix I guess I
> can make an exception.

I think it is fine to leave these, but to try to not have more in the future.

> Will git rewrite the commit msg when this is set ?  I'm at 2.28 and don't
> have core.abbrev set. But I guess this needs to be set in the gitconfig
> of the creator of the patch; and this has no impact on "git am" ?

It will not rewrite the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drivers-x86 tree

[Hans de Goede]

Hi Stephen,

On 11/29/20 6:43 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   912b341585e3 ("platform/x86: mlx-platform: Remove PSU EEPROM from MSN274x platform configuration")
> 
> Fixes tag
> 
>   Fixes: ef08e14a3 ("platform/x86: mlx-platform: Add support for new msn274x system type")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
> 
> In commit
> 
>   2bf5046bdb64 ("platform/x86: mlx-platform: Remove PSU EEPROM from default platform configuration")
> 
> Fixes tags
> 
>   Fixes: c6acad68e ("platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface")
>   Fixes: ba814fdd0 ("platform/x86: mlx-platform: Use defines for bus assignment")
> 
> have these problem(s):
> 
>   - SHA1 should be at least 12 digits long

Hmm, for some reason checkpatch did not catch these, while AFAIK it will complain
about short hashes in the normal part of the commit msg.

Question, how important is it to fix these ? I normally never do forced pushes
to the for-next branch. But if this is considered important to fix I guess I
can make an exception.

> These can be fixed in the future by setting core.abbrev to 12 (or more)
> or (for git v2.11 or later) just making sure it is not set (or set to
> "auto").

Will git rewrite the commit msg when this is set ?  I'm at 2.28 and don't
have core.abbrev set. But I guess this needs to be set in the gitconfig
of the creator of the patch; and this has no impact on "git am" ?

Regards,

Hans

linux-next: Fixes tag needs some work in the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

Hi all,

In commit

  912b341585e3 ("platform/x86: mlx-platform: Remove PSU EEPROM from MSN274x platform configuration")

Fixes tag

  Fixes: ef08e14a3 ("platform/x86: mlx-platform: Add support for new msn274x system type")

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  2bf5046bdb64 ("platform/x86: mlx-platform: Remove PSU EEPROM from default platform configuration")

Fixes tags

  Fixes: c6acad68e ("platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface")
  Fixes: ba814fdd0 ("platform/x86: mlx-platform: Use defines for bus assignment")

have these problem(s):

  - SHA1 should be at least 12 digits long

These can be fixed in the future by setting core.abbrev to 12 (or more)
or (for git v2.11 or later) just making sure it is not set (or set to
"auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drivers-x86 tree

[Andy Shevchenko]

On Fri, Apr 24, 2020 at 1:53 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   92f62e696851 ("platform/x86: intel_pmc_core: Change Jasper Lake S0ix debug reg map back to ICL")
>
> Fixes tag
>
>   Fixes: 16292bed9c ("platform/x86: intel_pmc_core: Add Atom based Jasper Lake (JSL) platform support")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Thanks, fixed now!

-- 
With Best Regards,
Andy Shevchenko

linux-next: Fixes tag needs some work in the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Hi all,

In commit

  92f62e696851 ("platform/x86: intel_pmc_core: Change Jasper Lake S0ix debug reg map back to ICL")

Fixes tag

  Fixes: 16292bed9c ("platform/x86: intel_pmc_core: Add Atom based Jasper Lake (JSL) platform support")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

Hi all,

In commit

  6cc13c28da5b ("platform/x86: dell-laptop: fix rfkill functionality")

Fixes tag

  Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drivers-x86 tree

[Andy Shevchenko]

On Thu, Feb 21, 2019 at 2:40 AM Darren Hart <dvhart@infradead.org> wrote:
> On Wed, Feb 13, 2019 at 08:45:56PM +0530, Bhardwaj, Rajneesh wrote:
> > On 07-Feb-19 9:25 PM, Andy Shevchenko wrote:
> > > On Thu, Feb 7, 2019 at 4:06 AM Bhardwaj, Rajneesh
> > > <rajneesh.bhardwaj@linux.intel.com> wrote:
> > > > On 07-Feb-19 4:27 AM, Stephen Rothwell wrote:

> > > > In commit
> > > >
> > > >    4284dc008f43 ("platform/x86: intel_pmc_core: Fix file permissions for ltr_show")
> > > >
> > > > Fixes tag
> > > >
> > > >    Fixes: 63cde0c16c67 ("platform/x86: intel_pmc_core: Show Latency Tolerance info")
> > > >
> > > > has these problem(s):
> > > >
> > > >    - Target SHA1 does not exist
> > > >
> > > > Did you mean:
> > > >
> > > >    2eb150558bb7 ("platform/x86: intel_pmc_core: Show Latency Tolerance info")
> > > >
> > > > Yes, upstream commit is 2eb150558bb79ee01c39b64c2868216c0be2904f. For some reason when i do git show on my repo with both these SHA1 i see the same patch.
> > > >
> > > > I will fix this in next version.
> > > Hmm... this came to our published branch, i.e. for-next, would it be
> > > better to update it via rebasing?
> > >
> > > Darren, what do you think?
> >
> > Hi Andy, I have corrected this in v2 anyway and i sent to upstream today,
> > just in case you prefer it over rebasing.
> >
> > https://patchwork.kernel.org/patch/10810123/
> >
>
> While we try hard not to rebase, if the choice is to rebase for-next or send a
> bad commit to upstream, I will opt for the rebase.
>
> Andy, I would suggest doing the rebase.

Okay, I do it right now then,

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: Fixes tag needs some work in the drivers-x86 tree

[Darren Hart]

On Wed, Feb 13, 2019 at 08:45:56PM +0530, Bhardwaj, Rajneesh wrote:
> 
> On 07-Feb-19 9:25 PM, Andy Shevchenko wrote:
> > On Thu, Feb 7, 2019 at 4:06 AM Bhardwaj, Rajneesh
> > <rajneesh.bhardwaj@linux.intel.com> wrote:
> > > On 07-Feb-19 4:27 AM, Stephen Rothwell wrote:
> > > 
> > > Hi all,
> > > 
> > > In commit
> > > 
> > >    4284dc008f43 ("platform/x86: intel_pmc_core: Fix file permissions for ltr_show")
> > > 
> > > Fixes tag
> > > 
> > >    Fixes: 63cde0c16c67 ("platform/x86: intel_pmc_core: Show Latency Tolerance info")
> > > 
> > > has these problem(s):
> > > 
> > >    - Target SHA1 does not exist
> > > 
> > > Did you mean:
> > > 
> > >    2eb150558bb7 ("platform/x86: intel_pmc_core: Show Latency Tolerance info")
> > > 
> > > Yes, upstream commit is 2eb150558bb79ee01c39b64c2868216c0be2904f. For some reason when i do git show on my repo with both these SHA1 i see the same patch.
> > > 
> > > I will fix this in next version.
> > Hmm... this came to our published branch, i.e. for-next, would it be
> > better to update it via rebasing?
> > 
> > Darren, what do you think?
> 
> Hi Andy, I have corrected this in v2 anyway and i sent to upstream today,
> just in case you prefer it over rebasing.
> 
> https://patchwork.kernel.org/patch/10810123/
> 

While we try hard not to rebase, if the choice is to rebase for-next or send a
bad commit to upstream, I will opt for the rebase.

Andy, I would suggest doing the rebase.

-- 
Darren Hart
VMware Open Source Technology Center

Re: linux-next: Fixes tag needs some work in the drivers-x86 tree

[Bhardwaj, Rajneesh]

On 07-Feb-19 9:25 PM, Andy Shevchenko wrote:
> On Thu, Feb 7, 2019 at 4:06 AM Bhardwaj, Rajneesh
> <rajneesh.bhardwaj@linux.intel.com> wrote:
>> On 07-Feb-19 4:27 AM, Stephen Rothwell wrote:
>>
>> Hi all,
>>
>> In commit
>>
>>    4284dc008f43 ("platform/x86: intel_pmc_core: Fix file permissions for ltr_show")
>>
>> Fixes tag
>>
>>    Fixes: 63cde0c16c67 ("platform/x86: intel_pmc_core: Show Latency Tolerance info")
>>
>> has these problem(s):
>>
>>    - Target SHA1 does not exist
>>
>> Did you mean:
>>
>>    2eb150558bb7 ("platform/x86: intel_pmc_core: Show Latency Tolerance info")
>>
>> Yes, upstream commit is 2eb150558bb79ee01c39b64c2868216c0be2904f. For some reason when i do git show on my repo with both these SHA1 i see the same patch.
>>
>> I will fix this in next version.
> Hmm... this came to our published branch, i.e. for-next, would it be
> better to update it via rebasing?
>
> Darren, what do you think?

Hi Andy, I have corrected this in v2 anyway and i sent to upstream 
today, just in case you prefer it over rebasing.

https://patchwork.kernel.org/patch/10810123/



>

Re: linux-next: Fixes tag needs some work in the drivers-x86 tree

[Andy Shevchenko]

On Thu, Feb 7, 2019 at 4:06 AM Bhardwaj, Rajneesh
<rajneesh.bhardwaj@linux.intel.com> wrote:
> On 07-Feb-19 4:27 AM, Stephen Rothwell wrote:
>
> Hi all,
>
> In commit
>
>   4284dc008f43 ("platform/x86: intel_pmc_core: Fix file permissions for ltr_show")
>
> Fixes tag
>
>   Fixes: 63cde0c16c67 ("platform/x86: intel_pmc_core: Show Latency Tolerance info")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Did you mean:
>
>   2eb150558bb7 ("platform/x86: intel_pmc_core: Show Latency Tolerance info")
>
> Yes, upstream commit is 2eb150558bb79ee01c39b64c2868216c0be2904f. For some reason when i do git show on my repo with both these SHA1 i see the same patch.
>
> I will fix this in next version.

Hmm... this came to our published branch, i.e. for-next, would it be
better to update it via rebasing?

Darren, what do you think?

-- 
With Best Regards,
Andy Shevchenko

linux-next: Fixes tag needs some work in the drivers-x86 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Hi all,

In commit

  4284dc008f43 ("platform/x86: intel_pmc_core: Fix file permissions for ltr_show")

Fixes tag

  Fixes: 63cde0c16c67 ("platform/x86: intel_pmc_core: Show Latency Tolerance info")

has these problem(s):

  - Target SHA1 does not exist

Did you mean:

  2eb150558bb7 ("platform/x86: intel_pmc_core: Show Latency Tolerance info")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]