From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A504C31E46 for ; Wed, 12 Jun 2019 07:46:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56DD02080A for ; Wed, 12 Jun 2019 07:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560325564; bh=HBZmv5Jn4n9YMcC+WRXXHUaGqXSrdl/9dvlD6Nov5CE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VW78EiNSseJnbEVL4Q824dWGzZA6qsyotfmiwQc2RJL77OrpxsF7Ra8/lWxmAC9na G+I10s2Hkv68nC6dGRRGRqr2xkAtxmdtiqu2odKMtMhyEsxbEGR/cGplAs+lhPkgyu Nn2Q4vLrm4RqIL8LO9b3Zl9K9oEsDkgaqMhOzJmE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436640AbfFLHqD (ORCPT ); Wed, 12 Jun 2019 03:46:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:43946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406508AbfFLHqD (ORCPT ); Wed, 12 Jun 2019 03:46:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 01FD72063F; Wed, 12 Jun 2019 07:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560325562; bh=HBZmv5Jn4n9YMcC+WRXXHUaGqXSrdl/9dvlD6Nov5CE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V93fDOv58OVuF84Uc+57iq7ktK3sbLn4eXKDOQ0FdpBC8DVe+hcp9xwb8VFhDhpk/ zJ+HbHKsCpFAu+Ivji7vr5PkY+YAqVUAXAqB0sWyp7EKrSpblnJM3dN6s2DbZueMI9 ivUk4cQDgo+1ohgOriBPHRPFm41Gc2Xlk+qKZL7M= Date: Wed, 12 Jun 2019 09:46:00 +0200 From: Greg KH To: Dan Carpenter Cc: Simon =?iso-8859-1?Q?Sandstr=F6m?= , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: kpc2000: remove unnecessary comments in kp2000_pcie_probe Message-ID: <20190612074600.GA17100@kroah.com> References: <20190610200535.31820-1-simon@nikanor.nu> <20190610200535.31820-3-simon@nikanor.nu> <20190612073936.GD1915@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190612073936.GD1915@kadam> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 12, 2019 at 10:39:36AM +0300, Dan Carpenter wrote: > On Mon, Jun 10, 2019 at 10:05:35PM +0200, Simon Sandström wrote: > > @@ -349,9 +340,7 @@ static int kp2000_pcie_probe(struct pci_dev *pdev, > > goto err_remove_ida; > > } > > > > - /* > > - * Step 4: Setup the Register BAR > > - */ > > + // Setup the Register BAR > > Greg, are we moving the C++ style comments? Linus is fine with them. I > don't like them but whatever... I don't like them either. I'm only "ok" with them on the very first line of the file. Linus chose // to make it "stand out" from the normal flow of the file, which is fine for an SPDX line. So putting these in here like this is not ok to me. thanks, greg k-h