From: Lee Jones <lee.jones@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
rafael@kernel.org, Corey Minyard <minyard@acm.org>,
Russell King <linux@armlinux.org.uk>,
Thierry Reding <thierry.reding@gmail.com>,
Will Deacon <will.deacon@arm.com>, Joerg Roedel <joro@8bytes.org>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Sebastian Ott <sebott@linux.ibm.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Nehal Shah <nehal-bakulchandra.shah@amd.com>,
Shyam Sundar S K <shyam-sundar.s-k@amd.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH 03/13] driver_find_device: Unify the match function with class_find_device()
Date: Wed, 12 Jun 2019 10:32:46 +0100 [thread overview]
Message-ID: <20190612093246.GE4797@dell> (raw)
In-Reply-To: <1559747630-28065-4-git-send-email-suzuki.poulose@arm.com>
On Wed, 05 Jun 2019, Suzuki K Poulose wrote:
> The driver_find_device() accepts a match function pointer to
> filter the devices for lookup, similar to bus/class_find_device().
> However, there is a minor difference in the prototype for the
> match parameter for driver_find_device() with the now unified
> version accepted by {bus/class}_find_device(), where it doesn't
> accept a "const" qualifier for the data argument. This prevents
> us from reusing the generic match functions for driver_find_device().
>
> For this reason, change the prototype of the driver_find_device() to
> make the "match" parameter in line with {bus/class}_find_device()
> and adjust its callers to use the const qualifier. Also, we could
> now promote the "data" parameter to const as we pass it down
> as a const parameter to the match functions.
>
> Cc: Corey Minyard <minyard@acm.org>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
> Cc: Sebastian Ott <sebott@linux.ibm.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Nehal Shah <nehal-bakulchandra.shah@amd.com>
> Cc: Shyam Sundar S K <shyam-sundar.s-k@amd.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> drivers/amba/tegra-ahb.c | 4 ++--
> drivers/base/driver.c | 4 ++--
> drivers/char/ipmi/ipmi_msghandler.c | 8 ++++----
> drivers/gpu/drm/tegra/dc.c | 4 ++--
> drivers/i2c/busses/i2c-amd-mp2-pci.c | 2 +-
> drivers/iommu/arm-smmu-v3.c | 2 +-
> drivers/iommu/arm-smmu.c | 2 +-
> drivers/mfd/altera-sysmgr.c | 4 ++--
> drivers/mfd/syscon.c | 2 +-
I'm okay with the changes. How do you plan on managing the merge?
> drivers/s390/cio/ccwgroup.c | 2 +-
> drivers/s390/cio/chsc_sch.c | 2 +-
> drivers/s390/cio/device.c | 2 +-
> include/linux/device.h | 4 ++--
> 13 files changed, 21 insertions(+), 21 deletions(-)
[...]
> diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c
> index 8976f82..2ee14d8 100644
> --- a/drivers/mfd/altera-sysmgr.c
> +++ b/drivers/mfd/altera-sysmgr.c
> @@ -92,9 +92,9 @@ static struct regmap_config altr_sysmgr_regmap_cfg = {
> * Matching function used by driver_find_device().
> * Return: True if match is found, otherwise false.
> */
> -static int sysmgr_match_phandle(struct device *dev, void *data)
> +static int sysmgr_match_phandle(struct device *dev, const void *data)
> {
> - return dev->of_node == (struct device_node *)data;
> + return dev->of_node == (const struct device_node *)data;
> }
>
> /**
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index 8ce1e41..4f39ba5 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -190,7 +190,7 @@ struct regmap *syscon_regmap_lookup_by_compatible(const char *s)
> }
> EXPORT_SYMBOL_GPL(syscon_regmap_lookup_by_compatible);
>
> -static int syscon_match_pdevname(struct device *dev, void *data)
> +static int syscon_match_pdevname(struct device *dev, const void *data)
> {
> return !strcmp(dev_name(dev), (const char *)data);
> }
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-06-12 9:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1559747630-28065-1-git-send-email-suzuki.poulose@arm.com>
2019-06-05 15:13 ` [PATCH 01/13] acpi: utils: Cleanup acpi_dev_match_cb Suzuki K Poulose
2019-06-06 9:14 ` Rafael J. Wysocki
2019-06-06 9:21 ` Suzuki K Poulose
2019-06-05 15:13 ` [PATCH 02/13] bus_find_device: Unify the match callback with class_find_device Suzuki K Poulose
2019-06-05 15:48 ` Corey Minyard
2019-06-05 15:51 ` Kershner, David A
2019-06-05 18:18 ` Mark Brown
2019-06-06 8:56 ` Rafael J. Wysocki
2019-06-06 9:01 ` Srinivas Kandagatla
2019-06-05 15:13 ` [PATCH 03/13] driver_find_device: Unify the match function with class_find_device() Suzuki K Poulose
2019-06-12 9:32 ` Lee Jones [this message]
2019-06-12 9:36 ` Suzuki K Poulose
2019-06-05 15:13 ` [PATCH 04/13] drivers: Add generic helper to match by of_node Suzuki K Poulose
2019-06-05 15:13 ` [PATCH 05/13] drivers: Add generic helper to match by fwnode Suzuki K Poulose
2019-06-05 15:13 ` [PATCH 06/13] drivers: Add generic helper to match by devt Suzuki K Poulose
2019-06-05 15:13 ` [PATCH 07/13] drivers: Add generic match helper by ACPI_COMPANION device Suzuki K Poulose
2019-06-06 9:17 ` Rafael J. Wysocki
2019-06-06 9:28 ` Suzuki K Poulose
2019-06-06 9:57 ` Rafael J. Wysocki
2019-06-12 9:43 ` Suzuki K Poulose
2019-06-12 22:07 ` Rafael J. Wysocki
2019-06-05 15:13 ` [PATCH 08/13] drivers: Add generic helper to match by name Suzuki K Poulose
2019-06-05 15:13 ` [PATCH 09/13] drivers: Add generic helper to match any device Suzuki K Poulose
2019-06-05 15:13 ` [PATCH 10/13] drivers: Introduce variants of class_find_device() Suzuki K Poulose
2019-06-05 16:14 ` Greg KH
2019-06-05 18:13 ` Suzuki K Poulose
2019-06-05 15:13 ` [PATCH 11/13] drivers: Introduce variants for bus_find_device() Suzuki K Poulose
2019-06-05 15:13 ` [PATCH 12/13] drivers: Introduce variants of driver_find_device() Suzuki K Poulose
2019-06-05 15:13 ` [PATCH 13/13] platform: Add platform_find_device_by_driver() helper Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612093246.GE4797@dell \
--to=lee.jones@linaro.org \
--cc=airlied@linux.ie \
--cc=borntraeger@de.ibm.com \
--cc=daniel@ffwll.ch \
--cc=gregkh@linuxfoundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=minyard@acm.org \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=oberpar@linux.ibm.com \
--cc=rafael@kernel.org \
--cc=sebott@linux.ibm.com \
--cc=shyam-sundar.s-k@amd.com \
--cc=suzuki.poulose@arm.com \
--cc=thierry.reding@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).