From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF1A5C31E48 for ; Wed, 12 Jun 2019 11:37:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FA6621744 for ; Wed, 12 Jun 2019 11:37:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438352AbfFLLhT (ORCPT ); Wed, 12 Jun 2019 07:37:19 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:40905 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438269AbfFLLhS (ORCPT ); Wed, 12 Jun 2019 07:37:18 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 7C0EA802EA; Wed, 12 Jun 2019 13:37:05 +0200 (CEST) Date: Wed, 12 Jun 2019 13:37:15 +0200 From: Pavel Machek To: Oleksandr Natalenko Cc: Minchan Kim , Andrew Morton , linux-mm , LKML , linux-api@vger.kernel.org, Michal Hocko , Johannes Weiner , Tim Murray , Joel Fernandes , Suren Baghdasaryan , Daniel Colascione , Shakeel Butt , Sonny Rao , Brian Geffon , jannh@google.com, oleg@redhat.com, christian@brauner.io, hdanton@sina.com, lizeb@google.com Subject: Re: [PATCH v2 0/5] Introduce MADV_COLD and MADV_PAGEOUT Message-ID: <20190612113715.GA21366@amd> References: <20190610111252.239156-1-minchan@kernel.org> <20190612105945.GA16442@amd> <20190612111920.evedpmre63ivnxkz@butterfly.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Content-Disposition: inline In-Reply-To: <20190612111920.evedpmre63ivnxkz@butterfly.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > This approach is similar in spirit to madvise(MADV_WONTNEED), but the > > > information required to make the reclaim decision is not known to the= app. > > > Instead, it is known to a centralized userspace daemon, and that daem= on > > > must be able to initiate reclaim on its own without any app involveme= nt. > > > To solve the concern, this patch introduces new syscall - > > >=20 > > > struct pr_madvise_param { > > > int size; /* the size of this structure */ > > > int cookie; /* reserved to support atomicity = */ > > > int nr_elem; /* count of below arrary fields */ > > > int __user *hints; /* hints for each range */ > > > /* to store result of each operation */ > > > const struct iovec __user *results; > > > /* input address ranges */ > > > const struct iovec __user *ranges; > > > }; > > > =20 > > > int process_madvise(int pidfd, struct pr_madvise_param *u_param, > > > unsigned long flags); > >=20 > > That's quite a complex interface. > >=20 > > Could we simply have feel_free_to_swap_out(int pid) syscall? :-). >=20 > I wonder for how long we'll go on with adding new syscalls each time we n= eed > some amendment to existing interfaces. Yes, clone6(), I'm looking at > you :(. >=20 > In case of process_madvise() keep in mind it will be focused not only on > MADV_COLD, but also, potentially, on other MADV_ flags as well. I can > hardly imagine we'll add one syscall per each flag. Use case described above talked about whole-process-at-a-time usage, so I'm asking if simpler interface/code is enough. If there's motivation for more complex version, it should be described here... Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl0A4+sACgkQMOfwapXb+vL5YQCghuEijV5YAvkI5fTH2VOxFvri GLwAoJHEuclcX7PmhKr8Ht0OQ4+EHl8w =CpBo -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh--