From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4E51C31E46 for ; Wed, 12 Jun 2019 13:16:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B5A3208C2 for ; Wed, 12 Jun 2019 13:16:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="XnSXT6Ub" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439391AbfFLNQv (ORCPT ); Wed, 12 Jun 2019 09:16:51 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:48612 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437430AbfFLNQv (ORCPT ); Wed, 12 Jun 2019 09:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZldakM9EWSeIneK5Mkn/ppneVbLd1+j1SRpOUGdQOH8=; b=XnSXT6Ubg98Jo9eUBlSoAHDTar I+dFWF4SzY6g56RnubYm7lqGcoF/KQaycNSGFSezHp8qmEK99EtMDvOwnB/EeN4RhZV8fJpO/P9hi nw/h94rALJhTVODhD2uYKiFowY2VDxH7uoObey9egacHOAacrZQGB6CNpOFr01kki8dE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hb37P-0004Ju-2w; Wed, 12 Jun 2019 15:16:47 +0200 Date: Wed, 12 Jun 2019 15:16:47 +0200 From: Andrew Lunn To: Linus Walleij Cc: Anders Roxell , "David S. Miller" , Vivien Didelot , Florian Fainelli , netdev , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] drivers: net: dsa: fix warning same module names Message-ID: <20190612131647.GD23615@lunn.ch> References: <20190612081147.1372-1-anders.roxell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 12, 2019 at 02:36:44PM +0200, Linus Walleij wrote: > On Wed, Jun 12, 2019 at 10:11 AM Anders Roxell wrote: > > > When building with CONFIG_NET_DSA_REALTEK_SMI and CONFIG_REALTEK_PHY > > enabled as loadable modules, we see the following warning: > > > > warning: same module names found: > > drivers/net/phy/realtek.ko > > drivers/net/dsa/realtek.ko > > > > Rework so the driver name is rtl8366 instead of realtek. > > > > Signed-off-by: Anders Roxell > > Sorry for giving bad advice here on IRC... my wrong. > > > -obj-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek.o > > -realtek-objs := realtek-smi.o rtl8366.o rtl8366rb.o > > +obj-$(CONFIG_NET_DSA_REALTEK_SMI) += rtl8366.o > > +rtl8366-objs := realtek-smi.o rtl8366-common.o rtl8366rb.o > > What is common for this family is not the name rtl8366 > (there is for example rtl8369 in this family, we just haven't > added it yet) but the common technical item is SMI. Hi Linus I was not sure about this. I thought SMI was the bus used to communicate with the switch. It just seemed odd to call a switch family after the bus. Anyway, if you are happy with the name realtek-smi: Reviewed-by: Andrew Lunn Andrew