From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-crypto@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Harald Freudenberger <freude@linux.ibm.com>
Subject: Re: [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP
Date: Wed, 12 Jun 2019 15:48:18 +0200 [thread overview]
Message-ID: <20190612154818.69a02949.cohuck@redhat.com> (raw)
In-Reply-To: <20190612133306.10231-1-david@redhat.com>
On Wed, 12 Jun 2019 15:33:02 +0200
David Hildenbrand <david@redhat.com> wrote:
> s390x crypto is one of the rare modules that returns -EOPNOTSUPP instead of
> -ENODEV in case HW support is not available.
>
> Convert to -ENODEV, so e.g., systemd's systemd-modules-load.service
> ignores this error properly.
>
> v2 -> v3:
> - "s390/pkey: Use -ENODEV instead of -EOPNOTSUPP"
> -- Also convert pkey_clr2protkey() as requested by Harald
Looks reasonable; my r-b still stands.
> - Add r-b's (thanks!)
>
> v1 -> v2:
> - Include
> -- "s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP"
> -- "s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP"
> -- "s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP"
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Harald Freudenberger <freude@linux.ibm.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
>
> David Hildenbrand (4):
> s390/pkey: Use -ENODEV instead of -EOPNOTSUPP
> s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP
> s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP
> s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP
>
> arch/s390/crypto/ghash_s390.c | 2 +-
> arch/s390/crypto/prng.c | 4 ++--
> arch/s390/crypto/sha1_s390.c | 2 +-
> arch/s390/crypto/sha256_s390.c | 2 +-
> arch/s390/crypto/sha512_s390.c | 2 +-
> drivers/s390/crypto/pkey_api.c | 8 ++++----
> 6 files changed, 10 insertions(+), 10 deletions(-)
>
next prev parent reply other threads:[~2019-06-12 13:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 13:33 [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP David Hildenbrand
2019-06-12 13:33 ` [PATCH v3 1/4] s390/pkey: " David Hildenbrand
2019-06-12 13:33 ` [PATCH v3 2/4] s390/crypto: ghash: " David Hildenbrand
2019-06-12 13:33 ` [PATCH v3 3/4] s390/crypto: prng: " David Hildenbrand
2019-06-12 13:33 ` [PATCH v3 4/4] s390/crypto: sha: " David Hildenbrand
2019-06-12 13:48 ` Cornelia Huck [this message]
2019-06-12 15:08 ` [PATCH v3 0/4] s390/crypto: " Heiko Carstens
2019-06-13 3:13 ` Herbert Xu
2019-06-13 7:51 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612154818.69a02949.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).