From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6012C31E45 for ; Thu, 13 Jun 2019 16:15:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8ED08208CA for ; Thu, 13 Jun 2019 16:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560442555; bh=32RJqGO3C8WFy8yJ+VFstTzfIIsdO5tnH9ziPinK1RI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YOMOPNKfyOZweYLqoVrmchpokxeaNJRDcTDsNhg7pXFBltd96j88UeP9oO03yVUmi 6rYOq29RYcP3NKTzh1MY6hVQw9w6OQtYD/6d1pHhFIYPieimdiTYASRRz5RKUQ98yz SnX3Ks+nmbNSJQtwi14T7HuVTjr3aGRPrlHFslZc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391650AbfFMQPu (ORCPT ); Thu, 13 Jun 2019 12:15:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:58872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731167AbfFMIlm (ORCPT ); Thu, 13 Jun 2019 04:41:42 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8262721479; Thu, 13 Jun 2019 08:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560415302; bh=32RJqGO3C8WFy8yJ+VFstTzfIIsdO5tnH9ziPinK1RI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jHtQ1FHCZ/5Na3rrWsqCn2+xUaTASIPHjA4jDULhlkonrg+A4YwjYTUTBKEBRqx5t s38SqA0JsNIpb/HLxt6voaiJaixuzJDFzAB9FFl2yZuacGJPP0kgzFmyV9g6hVgTmc AwiCuzZUjQpbo4h1siFyMU2lV2v7l84kLCInHiok= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Arnd Bergmann , Matthias Brugger , Sasha Levin Subject: [PATCH 4.19 077/118] soc: mediatek: pwrap: Zero initialize rdata in pwrap_init_cipher Date: Thu, 13 Jun 2019 10:33:35 +0200 Message-Id: <20190613075648.328559204@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190613075643.642092651@linuxfoundation.org> References: <20190613075643.642092651@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 89e28da82836530f1ac7a3a32fecc31f22d79b3e ] When building with -Wsometimes-uninitialized, Clang warns: drivers/soc/mediatek/mtk-pmic-wrap.c:1358:6: error: variable 'rdata' is used uninitialized whenever '||' condition is true [-Werror,-Wsometimes-uninitialized] If pwrap_write returns non-zero, pwrap_read will not be called to initialize rdata, meaning that we will use some random uninitialized stack value in our print statement. Zero initialize rdata in case this happens. Link: https://github.com/ClangBuiltLinux/linux/issues/401 Signed-off-by: Nathan Chancellor Reviewed-by: Nick Desaulniers Reviewed-by: Arnd Bergmann Signed-off-by: Matthias Brugger Signed-off-by: Sasha Levin --- drivers/soc/mediatek/mtk-pmic-wrap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c index 4e931fdf4d09..011a40b5fb49 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -1104,7 +1104,7 @@ static bool pwrap_is_pmic_cipher_ready(struct pmic_wrapper *wrp) static int pwrap_init_cipher(struct pmic_wrapper *wrp) { int ret; - u32 rdata; + u32 rdata = 0; pwrap_writel(wrp, 0x1, PWRAP_CIPHER_SWRST); pwrap_writel(wrp, 0x0, PWRAP_CIPHER_SWRST); -- 2.20.1