From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D766BC31E49 for ; Thu, 13 Jun 2019 16:12:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A696B20679 for ; Thu, 13 Jun 2019 16:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560442328; bh=QEZFKU/g/ch1pLN7vInXMfAeh/fGDxksb2zdlg6jy5c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MZCwbbo2Y+rsJce/S1gbrQgjaC8N7ol/ngWqLvUiauZQq+YcgNJUJvHEwtAVWrm/q J6w8pta9mhlUBxwkncMOIphZHPRVvq+kaqKiB4rOOfTRcLdH/wWLSZgkLZTuPyS0g+ NeLcEa5dTViivqP3Z8vJmRqUJmXNcH7uhZAUXMK8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727966AbfFMQMD (ORCPT ); Thu, 13 Jun 2019 12:12:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:60432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731225AbfFMInQ (ORCPT ); Thu, 13 Jun 2019 04:43:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6029B2063F; Thu, 13 Jun 2019 08:43:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560415395; bh=QEZFKU/g/ch1pLN7vInXMfAeh/fGDxksb2zdlg6jy5c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WhtWcyuz3o/LSXUSlLJFYx96dqsclVneHTkSWCPFoeHQyozhTDfAdOrZfYg5XlfPb 1n0cfQskmKlBwZbpM7K4j4x9YnEd1hmgkn5Mmot5ve4cXcYVnQqE39laaFa2k5uo2G t7Lltiu6zPmvJWZYJuCkvn5PXKca4TXrZ6LJSkWg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede , Heikki Krogerus , Guenter Roeck , Sasha Levin Subject: [PATCH 4.19 110/118] usb: typec: fusb302: Check vconn is off when we start toggling Date: Thu, 13 Jun 2019 10:34:08 +0200 Message-Id: <20190613075650.543756529@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190613075643.642092651@linuxfoundation.org> References: <20190613075643.642092651@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 32a155b1a83d6659e2272e8e1eec199667b1897e ] The datasheet says the vconn MUST be off when we start toggling. The tcpm.c state-machine is responsible to make sure vconn is off, but lets add a WARN to catch any cases where vconn is not off for some reason. Signed-off-by: Hans de Goede Acked-by: Heikki Krogerus Reviewed-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/typec/fusb302/fusb302.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/typec/fusb302/fusb302.c b/drivers/usb/typec/fusb302/fusb302.c index 82bed9810be6..62a0060d39d8 100644 --- a/drivers/usb/typec/fusb302/fusb302.c +++ b/drivers/usb/typec/fusb302/fusb302.c @@ -641,6 +641,8 @@ static int fusb302_set_toggling(struct fusb302_chip *chip, return ret; chip->intr_togdone = false; } else { + /* Datasheet says vconn MUST be off when toggling */ + WARN(chip->vconn_on, "Vconn is on during toggle start"); /* unmask TOGDONE interrupt */ ret = fusb302_i2c_clear_bits(chip, FUSB_REG_MASKA, FUSB_REG_MASKA_TOGDONE); -- 2.20.1