From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99E43C31E45 for ; Thu, 13 Jun 2019 16:09:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66538208CA for ; Thu, 13 Jun 2019 16:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560442161; bh=S5A7UTeQWhWBtP5fYLh/wg3KEQnbgwNH5S8HaOS8f1Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Qg2O/unEICmsb2lZ4CmvgZVOdpxDq6eHSshDKJE4A73YPCu9HiCFPtYmnFQ+fQHfs zIQgM/4TQjQ/LtRANySunv0dIoVjekDUFXkThPGs72ILDfEyRJIZW6b81n83NAkNUW dIoIrgb+Xg4PGdqRIbsn6CwxrUHHJvPdj54/LvNI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391385AbfFMQJU (ORCPT ); Thu, 13 Jun 2019 12:09:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:33358 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731262AbfFMIo1 (ORCPT ); Thu, 13 Jun 2019 04:44:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2EEF42173C; Thu, 13 Jun 2019 08:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560415466; bh=S5A7UTeQWhWBtP5fYLh/wg3KEQnbgwNH5S8HaOS8f1Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SocppfwY08nWCb0Rm+nR7PtrIxCw9SHT4YUxIkLB1GTqBn/bHKzdlYB/AmemaIBGQ HjwRfRfgvAPr27WLS2rzvPM4GB9WNMuju7kIaJHnqPSm2tHJf8ZaM9Q2MF+oSJdGIu bYK76tvZuAmMuKXjuiRUEn5wNBAV36gl54nqkIlM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu , Alexandre Bounine , Matt Porter , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH 5.1 004/155] rapidio: fix a NULL pointer dereference when create_workqueue() fails Date: Thu, 13 Jun 2019 10:31:56 +0200 Message-Id: <20190613075652.964720344@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190613075652.691765927@linuxfoundation.org> References: <20190613075652.691765927@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 23015b22e47c5409620b1726a677d69e5cd032ba ] In case create_workqueue fails, the fix releases resources and returns -ENOMEM to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Acked-by: Alexandre Bounine Cc: Matt Porter Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- drivers/rapidio/rio_cm.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c index cf45829585cb..b29fc258eeba 100644 --- a/drivers/rapidio/rio_cm.c +++ b/drivers/rapidio/rio_cm.c @@ -2147,6 +2147,14 @@ static int riocm_add_mport(struct device *dev, mutex_init(&cm->rx_lock); riocm_rx_fill(cm, RIOCM_RX_RING_SIZE); cm->rx_wq = create_workqueue(DRV_NAME "/rxq"); + if (!cm->rx_wq) { + riocm_error("failed to allocate IBMBOX_%d on %s", + cmbox, mport->name); + rio_release_outb_mbox(mport, cmbox); + kfree(cm); + return -ENOMEM; + } + INIT_WORK(&cm->rx_work, rio_ibmsg_handler); cm->tx_slot = 0; -- 2.20.1