From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B03FDC31E45 for ; Thu, 13 Jun 2019 16:08:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8498E20679 for ; Thu, 13 Jun 2019 16:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560442111; bh=Rg9J8u8/6rpgKgaXt5tFW1M/y8ShsrCS08QD82ERM4g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oTWYRrZbeR7yHLj1WXiobP66PSoZiwKYKIIp6GLWDcux8SAKgpOrb+MvDM93L4/M6 HuPkPgJT0RU5LIJae68RYedUW4rvAAuaIGiV5BawtDhxpTZxR711eoIuWNB6qgE5tL wPXACWZiqNcKh3tYwRLdHGTVuHgK/ZOJeKnjEFOc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391168AbfFMQIU (ORCPT ); Thu, 13 Jun 2019 12:08:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:33928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731286AbfFMIpH (ORCPT ); Thu, 13 Jun 2019 04:45:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C97922147A; Thu, 13 Jun 2019 08:45:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560415507; bh=Rg9J8u8/6rpgKgaXt5tFW1M/y8ShsrCS08QD82ERM4g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nsouBOO72DT/Gu/t+XjYM+zeDMKXO7K7e3qoKFct73SABqvQDRIjiCaXCk0VuwYYJ tIXHymli0Hw5498QsVp9VWKB0FjkBFnN2tCs13uKx/qRe1VKjDL/OO5iEOZg9bYH4I 7d0EITU875xPGdtE2DYYCB/caEfeZA+Z80H1v+uM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Amit Kucheria , Eduardo Valentin , Sasha Levin Subject: [PATCH 5.1 026/155] drivers: thermal: tsens: Dont print error message on -EPROBE_DEFER Date: Thu, 13 Jun 2019 10:32:18 +0200 Message-Id: <20190613075654.302800358@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190613075652.691765927@linuxfoundation.org> References: <20190613075652.691765927@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit fc7d18cf6a923cde7f5e7ba2c1105bb106d3e29a ] We print a calibration failure message on -EPROBE_DEFER from nvmem/qfprom as follows: [ 3.003090] qcom-tsens 4a9000.thermal-sensor: version: 1.4 [ 3.005376] qcom-tsens 4a9000.thermal-sensor: tsens calibration failed [ 3.113248] qcom-tsens 4a9000.thermal-sensor: version: 1.4 This confuses people when, in fact, calibration succeeds later when nvmem/qfprom device is available. Don't print this message on a -EPROBE_DEFER. Signed-off-by: Amit Kucheria Signed-off-by: Eduardo Valentin Signed-off-by: Sasha Levin --- drivers/thermal/qcom/tsens.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index f1ec9bbe4717..54b2c0e3c4f4 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -160,7 +160,8 @@ static int tsens_probe(struct platform_device *pdev) if (tmdev->ops->calibrate) { ret = tmdev->ops->calibrate(tmdev); if (ret < 0) { - dev_err(dev, "tsens calibration failed\n"); + if (ret != -EPROBE_DEFER) + dev_err(dev, "tsens calibration failed\n"); return ret; } } -- 2.20.1