From: Mark Brown <broonie@kernel.org>
To: Thomas Preston <thomas.preston@codethink.co.uk>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Marco Felsch <m.felsch@pengutronix.de>,
Paul Cercueil <paul@crapouillou.net>,
Kirill Marinushkin <kmarinushkin@birdec.tech>,
Cheng-Yi Chiang <cychiang@chromium.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Vinod Koul <vkoul@kernel.org>,
Annaliese McDermond <nh6z@nh6z.net>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/4] ASoC: tda7802: Add enable device attribute
Date: Thu, 13 Jun 2019 19:14:43 +0100 [thread overview]
Message-ID: <20190613181443.GQ5316@sirena.org.uk> (raw)
In-Reply-To: <20190611174909.12162-4-thomas.preston@codethink.co.uk>
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
On Tue, Jun 11, 2019 at 06:49:08PM +0100, Thomas Preston wrote:
> Add a device attribute to control the enable regulator. Write 1 to
> enable, 0 to disable (ref-count minus one), or -1 to force disable the
> physical pin.
> To disable a set of amplifiers wired to the same enable gpio, each
> device must be disabled. For example:
> echo 0 > /sys/devices/.../device:00/enable
> echo 0 > /sys/devices/.../device:01/enable
This is adding a new ABI completely outstide the standard ALSA and power
management frameworks and ABIs with no explanation as to why or
integration with the rest of the driver. This is obviously not in the
slightest bit OK. If there's something missing from the frameworks
extend the frameworks, don't just ignore them.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-13 18:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 17:49 [PATCH v1 0/4] ASoC: Codecs: Add TDA7802 codec Thomas Preston
2019-06-11 17:49 ` [PATCH v1 1/4] dt-bindings: ASoC: Add TDA7802 amplifier Thomas Preston
2019-06-12 8:10 ` Charles Keepax
2019-06-11 17:49 ` [PATCH v1 2/4] ASoC: Add codec driver for ST TDA7802 Thomas Preston
2019-06-13 18:34 ` Mark Brown
2019-06-14 21:17 ` Kirill Marinushkin
2019-06-11 17:49 ` [PATCH v1 3/4] ASoC: tda7802: Add enable device attribute Thomas Preston
2019-06-12 17:14 ` Cezary Rojewski
2019-06-13 18:14 ` Mark Brown [this message]
2019-06-11 17:49 ` [PATCH v1 4/4] ASoC: tda7802: Add speaker-test sysfs Thomas Preston
2019-06-12 17:56 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613181443.GQ5316@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=cychiang@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kmarinushkin@birdec.tech \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=nh6z@nh6z.net \
--cc=paul@crapouillou.net \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=thomas.preston@codethink.co.uk \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).